Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

CouchrestModel Updates #76

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
4 participants

Dears,

kindly, find my share for some couchrest_model updates :

  • set couchrest_model default ORM in upcoming Rails 3.1
  • updates in couchrest_model model generator for CastedModel, Timestamps, ...
  • new generator for initialize CouchrestModel initializer and configuration file couchdb.yml
  • add the new ActiveModel SecurePassword to CouchrestModel Base.

Best Regards,
Shenouda Bertel

Owner

tapajos commented May 31, 2011

Shenouda Bertel,

I will test it tomorrow night.

Regards

Owner

tapajos commented Jun 8, 2011

Shenouda Bertel,

I've tested your pull request and I think that everything is ok. I don't think that is a good idea merge it before Rails 3.1 release.

Make sense?

Dear Marcos,

kindly, thanks for the good news and for taking time for testing my pull.
it's a good idea to merge the pull after Rails 3.1 release to the master rep.

Owner

tapajos commented Aug 21, 2011

We still waiting the Rails 3.1... :-(

Rails 3.1 is here now any chance on getting a new gem build with these changes.

Owner

tapajos commented Sep 4, 2011

I agree with this pull request. @samlown ? Can I merge it?

Owner

samlown commented Sep 6, 2011

HI Tapajos! IMHO, there are just too many changes here to be merged into a single pull, and of course no tests. (It would be nice to know that they do actually generate things!) I'm not convinced ActiveModel::SecurePassword should be added by default either, especially with no tests (I actually use it, so I know it works, but I think there should at least be something that tests its there.)

If you're up to fixing these issues in your merge I think they'd make a great addition :-)

Cheers, sam

Owner

samlown commented Sep 4, 2012

Closing this due to lack of activity. We're on Rails 3.2 anyway now!

@samlown samlown closed this Sep 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment