diff --git a/.eslintrc b/.eslintrc index 7abf4a5a..af1830c7 100644 --- a/.eslintrc +++ b/.eslintrc @@ -16,7 +16,7 @@ "rules": { "semi": ["error", "always"], "quotes": ["error", "single"], - "no-console": 0, + "no-console": 2, "no-param-reassign": 0, "react/jsx-filename-extension": 0, "import/no-extraneous-dependencies": 0, diff --git a/README.md b/README.md index 6c165745..90f15d39 100644 --- a/README.md +++ b/README.md @@ -70,15 +70,18 @@ The Following componets were ported: - Form ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Form)) ([Docs](http://bulma.io/documentation/form/general/)) - Heading (Title, Subtitle and heading on Bulma) ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Heading)) ([Docs](http://bulma.io/documentation/elements/title/)) - Hero ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Hero)) ([Docs](http://bulma.io/documentation/layout/hero/)) -- Image ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Image)) ([Docs](http://bulma.io/documentation/elements/image/)) - Icon ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Icon)) ([Docs](http://bulma.io/documentation/elements/icon/)) +- Image ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Image)) ([Docs](http://bulma.io/documentation/elements/image/)) - Level ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Level)) ([Docs](http://bulma.io/documentation/layout/level/)) +- Loader ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Loader)) - Media ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Media)) ([Docs](http://bulma.io/documentation/layout/media-object/)) - Modal ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Modal)) ([Docs](http://bulma.io/documentation/components/modal/)) - Navbar ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Navbar)) ([Docs](https://bulma.io/documentation/components/navbar/)) - Notification ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Notification)) ([Docs](http://bulma.io/documentation/elements/notification/)) +- Pagination ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Pagination)) ([Docs](https://bulma.io/documentation/components/pagination/)) - Progress ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Progress)) ([Docs](http://bulma.io/documentation/elements/progress/)) - Section ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Section)) ([Docs](http://bulma.io/documentation/layout/section/)) +- Tabs ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Tabs)) ([Docs](https://bulma.io/documentation/components/tabs/)) - Table ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Table)) ([Docs](http://bulma.io/documentation/elements/table/)) - Tag ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Tag)) ([Docs](http://bulma.io/documentation/elements/tag/)) - Tile ([Storybook](https://couds.github.io/react-bulma-components/?selectedKind=Tile)) ([Docs](http://bulma.io/documentation/layout/tiles/)) diff --git a/package.json b/package.json index e12827b6..61528899 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "react-bulma-components", - "version": "1.1.0", + "version": "1.1.1", "description": "React components for Bulma framework", "main": "dist", "scripts": { @@ -25,8 +25,16 @@ "type": "git", "url": "git+https://github.com/couds/react-bulma-components.git" }, - "keywords": [], - "author": "", + "keywords": [ + "react", + "bulma", + "bulma.io", + "css", + "bootstrap", + "modal", + "layout" + ], + "author": "John Benavides", "license": "MIT", "bugs": { "url": "https://github.com/couds/react-bulma-components/issues" @@ -42,26 +50,26 @@ "react-dom": "^16.2.0" }, "devDependencies": { - "@storybook/addon-a11y": "^3.2.17", - "@storybook/addon-actions": "^3.2.17", - "@storybook/addon-backgrounds": "^3.2.17", - "@storybook/addon-centered": "^3.2.17", - "@storybook/addon-events": "^3.2.17", - "@storybook/addon-info": "^3.2.17", - "@storybook/addon-jest": "^3.2.17", - "@storybook/addon-knobs": "^3.2.17", - "@storybook/addon-links": "^3.2.17", - "@storybook/addon-notes": "^3.2.17", - "@storybook/addon-options": "^3.2.17", - "@storybook/addon-storyshots": "^3.2.17", - "@storybook/addons": "^3.2.17", - "@storybook/components": "^3.2.17", - "@storybook/react": "^3.2.17", + "@storybook/addon-a11y": "^3.2.18", + "@storybook/addon-actions": "^3.2.18", + "@storybook/addon-backgrounds": "^3.2.18", + "@storybook/addon-centered": "^3.2.18", + "@storybook/addon-events": "^3.2.18", + "@storybook/addon-info": "^3.2.18", + "@storybook/addon-jest": "^3.2.18", + "@storybook/addon-knobs": "^3.2.18", + "@storybook/addon-links": "^3.2.18", + "@storybook/addon-notes": "^3.2.18", + "@storybook/addon-options": "^3.2.18", + "@storybook/addon-storyshots": "^3.2.18", + "@storybook/addons": "^3.2.18", + "@storybook/components": "^3.2.18", + "@storybook/react": "^3.2.18", "@storybook/storybook-deployer": "2.2.0", "babel-cli": "6.26.0", "babel-core": "6.26.0", "babel-eslint": "8.0.3", - "babel-jest": "21.2.0", + "babel-jest": "22.0.3", "babel-loader": "7.1.2", "babel-plugin-add-module-exports": "0.2.1", "babel-plugin-syntax-object-rest-spread": "6.13.0", @@ -77,7 +85,7 @@ "coveralls": "3.0.0", "css-loader": "0.28.7", "enzyme": "3.2.0", - "enzyme-adapter-react-16": "1.1.0", + "enzyme-adapter-react-16": "1.1.1", "eslint": "4.13.1", "eslint-config-airbnb": "16.1.0", "eslint-import-resolver-webpack": "0.8.3", @@ -87,10 +95,10 @@ "eslint-plugin-react": "7.5.1", "extract-text-webpack-plugin": "3.0.2", "file-loader": "1.1.6", - "jest": "21.2.1", + "jest": "22.0.3", "jsdom": "11.5.1", "node-sass": "4.7.2", - "nodemon": "1.13.3", + "nodemon": "1.14.0", "null-loader": "0.1.1", "optimize-css-assets-webpack-plugin": "3.2.0", "postcss-loader": "2.0.9", diff --git a/src/components/box/box.js b/src/components/box/box.js index ed773180..c9188300 100644 --- a/src/components/box/box.js +++ b/src/components/box/box.js @@ -23,13 +23,13 @@ export default class Box extends PureComponent { const { children, className, - style, renderAs, + ...props } = this.props; const Element = renderAs; return ( {children} diff --git a/src/components/breadcrumb/__test__/breadcrumb.test.js b/src/components/breadcrumb/__test__/breadcrumb.test.js index 98fd867e..5726a6cb 100644 --- a/src/components/breadcrumb/__test__/breadcrumb.test.js +++ b/src/components/breadcrumb/__test__/breadcrumb.test.js @@ -11,9 +11,11 @@ const Anchor = ({ describe('Breadcrumb component', () => { beforeEach(() => { + // eslint-disable-next-line no-console console.warn = jest.genMockFn(); }); afterAll(() => { + // eslint-disable-next-line no-console console.warn.mockRestore(); }); it('Should be a Breadcrumb', () => { diff --git a/src/components/breadcrumb/breadcrumb.js b/src/components/breadcrumb/breadcrumb.js index 9bc6ce45..4ec512a2 100644 --- a/src/components/breadcrumb/breadcrumb.js +++ b/src/components/breadcrumb/breadcrumb.js @@ -35,21 +35,22 @@ export default class Breadcrumb extends PureComponent { render() { const { className, - style, items, renderAs, hrefAttr, separator, size, align, + ...props } = this.props; if (renderAs !== 'a' && !hrefAttr) { + // eslint-disable-next-line no-console console.warn('if renderAs is different the anchor (a), hrefAttr is required. Check Breadcrumb props'); } const Element = renderAs; return (