This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
[apps] Simple swap app #1796
Closed
[apps] Simple swap app #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this - we'll probably change the base branch for this but it shouldn't effect the actual PR itself. |
|
Cool, just wanted to get this into the erc20 branch before it got merged and released. |
|
We should do any ERC20 PRs and this one in separate PRs |
|
@IIIIllllIIIIllllIIIIllllIIIIllllIIIIll yeah that's why I mentioned changing the base branch |
|
OK, I changed the base branch to be master instead of ERC20. We can merge this after that branch is merged, please ping me when it's ready. |
|
Changed it back to |
rhlsthrm
requested review from
Alonski,
cf19drofxots,
ebryn,
joelalejandro and
briarsweetbriar
as code owners
|
Updated based on a conversation with @snario today. Should be good to go! |
|
Closing in favor of merging: #1836 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exchange functionality in app.
Related issues