Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.22 #50

Closed
Krinkle opened this issue Nov 8, 2018 · 6 comments

Comments

@Krinkle
Copy link
Contributor

commented Nov 8, 2018

  • Promote master branch to 1.22.0-beta.1 (this allows us to distinguish with BotName version on IRC from 1.22.0-alpha).
  • Upgrade 1 CVNBot to the latest version.
    https://github.com/countervandalism/infrastructure/blob/master/tasks.yaml#L98
  • Slowly upgrade the other CVNBot instances on cvn-app servers to the latest version.
  • In case of any issues, fix the bugs, increase beta version, and start again.
  • Once applied to all instances without issues for a week, update change log, and bump master branch to 1.22.0 (stable).
  • Create tag v1.22.0 tag in git.
  • Bump master branch to 3.0.0-alpha.

Deployment for 1.22.0-beta.1

  • CVNBot18 (cvn-app8)

Deployment for 1.22.0-beta.2

  • cvn-app8
    • Cubbie
    • CVNBot1
    • CVNBot2
    • CVNBot3
    • CVNBot4
    • CVNBot5
    • CVNBot18

Deployment for 1.22.0-beta.3

  • cvn-app8
    • Cubbie
    • CVNBot1
    • CVNBot2
    • CVNBot3
    • CVNBot4
    • CVNBot5
    • CVNBot12
    • CVNBot13
    • CVNBot14
    • CVNBot18
    • CVNBot20
    • CVNBot21
    • SWBot3
  • cvn-app9
    • CVNBot6
    • CVNBot7
    • CVNBot8
    • CVNBot9
    • CVNBot10
    • CVNBot16
    • CVNBot17
    • CVNBot19
    • CVNBot22
    • CVNBot23
    • CVNBot24
    • CVNBot25
    • CVNBot26
    • CVNBot27
    • CVNBot28
    • CVNBot29

@Krinkle Krinkle added the meta label Nov 8, 2018

@Krinkle Krinkle self-assigned this Nov 8, 2018

Krinkle added a commit that referenced this issue Nov 8, 2018
Krinkle added a commit that referenced this issue Nov 9, 2018

@Krinkle Krinkle added this to the 1.22 milestone Dec 27, 2018

@Krinkle

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2018

I've upgraded CVNBot18 to 1.22.0-beta.1 (feeds cvn-wikidata, runs on cvn-app8).

@Krinkle

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2019

I've tagged the next beta and upgraded CVNBot18, Cubbie, CVNBot1-5 to 1.22.0-beta.2 (all on cvn-app8).

@Krinkle

This comment has been minimized.

Copy link
Contributor Author

commented Jul 21, 2019

Cubbie is crashing on start up:

Jul 21 19:56:02 cvn-app8 CVNBot.exe[8647]:

ERROR [Main] CVNBot.Program [Cubbie]

Caught unhandled exception in global catcher#012System.Collections.Generic.KeyNotFoundException:
  The given key 'reblockRegex' was not present in the dictionary.

  #012  at System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) <0x7f70ef7c83c0 + 0x00074> in <3833a6edf2074b959d3dab898627f0ac>:0
  #012  at CVNBot.Project.GenerateRegexen () [0x0014f] in <0ed46a4f75d24dd5b8e72cf04d480d64>:0
  #012  at CVNBot.Project.ReadProjectDetails (System.String xml) [0x00475] in <0ed46a4f75d24dd5b8e72cf04d480d64>:0
  #012  at CVNBot.ProjectList.LoadFromFile () [0x0005d] in <0ed46a4f75d24dd5b8e72cf04d480d64>:0
  #012  at CVNBot.Program.Main () [0x006d6] in <0ed46a4f75d24dd5b8e72cf04d480d64>:0

Krinkle added a commit that referenced this issue Jul 21, 2019
Project: Fix KeyNotFoundException from generateRegexen()
Follows-up 38aeefb (#47). This kept the `==` check that was
originally added in df39aaa. But, when using Dictionary, accessing
a key as dict[key] causes `System.Collections.Generic.KeyNotFoundException`
to be thrown.

To check existence, use ContainsKey instead.

Ref #50.
Krinkle added a commit that referenced this issue Jul 21, 2019
@Krinkle

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

I've fixed the regression in 48e03f1, tagged release 1.22.0-beta.3 , and re-started the upgrade plan (see comment 0).

@Krinkle

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

The upgrade to beta.3 happen on July 21st. Here's some monitoring graphs for the 3 days since then, compared to past week, month and year.

CPU

Graph of cpu from cvn-app8 by week, month, and year

Load Average

Graph of load average from cvn-app8 by week, month, and year

age

Memory

Graph of memory usage from cvn-app8 by week, month, and year

@Krinkle

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

This all looks good to me, so I'm gonna continue with the upgrades, following the docs.

Krinkle added a commit that referenced this issue Jul 31, 2019
Tag v1.22.0
Ref #50.
Krinkle added a commit that referenced this issue Jul 31, 2019
Tag v1.22.0
Ref #50.
Krinkle added a commit that referenced this issue Jul 31, 2019
Tag v1.22.0
Ref #50.
Krinkle added a commit that referenced this issue Jul 31, 2019
Tag v1.22.0
Ref #50.
Krinkle added a commit that referenced this issue Jul 31, 2019

@Krinkle Krinkle closed this Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.