Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setup.py #288

Closed
wants to merge 4 commits into from
Closed

Added setup.py #288

wants to merge 4 commits into from

Conversation

@mshytikov
Copy link
Contributor

@mshytikov mshytikov commented Nov 18, 2014

Hi

I have created the simple setup.py to improve installation process via packaging.
The coursera-dl can be submitted to PyPi and the installation for end user will be much simpler:
pip install coursera-dl (all dependencies will be installed automatically)
and the usage will be - 'you can run command coursera-dl ... from any directory and without worrying of PATH variable'

While it is not yet available on PyPi it can be built and installed locally.
to build a package:
python setup.py build sdist
to install it:
pip install dist/coursera-dl-*.tar.gz

P.S. The only thing which can be potentially broken is a Windows support.

@mshytikov mshytikov changed the title Add setup Added setup.py Nov 18, 2014
@coveralls
Copy link

@coveralls coveralls commented Nov 18, 2014

Coverage Status

Coverage increased (+0.04%) when pulling 9fb4e8c on mshytikov:add-setup into 3a970ab on coursera-dl:master.

@rbrito
Copy link
Member

@rbrito rbrito commented Nov 19, 2014

Dear @mshytikov,

On Nov 17 2014, Max Shytikov wrote:

I have created the simple setup.py to improve installation process via packaging.
The coursera-dl can be submitted to PyPi and the installation for end user will be much simpler:
pip install coursera-dl (all dependencies will be installed automatically)
and the usage will be - 'you can run command coursera-dl ... from any
directory and without worrying of PATH variable'

Thank you very much for your pull request. This is highly appreciated, since
I have been meaning to do this myself, but never actually went to the
trouble of setting up a setup script.

I have a few questions about your commits, which I plan on comment in the
next few days. If I don't comment, please do ping me.

Thanks a lot,

Rogério Brito.

Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA
http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

@mshytikov
Copy link
Contributor Author

@mshytikov mshytikov commented Nov 20, 2014

Dear @rbrito

Thank you for the reply.

Actually, my initial problem was to quickly backup one of the Coursera course on my home laptop (Mac OS). But unfortunately pip, virtualenv etc. were not in-place, and I didn't have time to go deep into installation process.
As result I decided to create a simple Docker image to solve problem described above.
Now I can use coursera-dl without worrying about python environment, installation and setup.
I hope someone finds it useful.

Looking forward for your comments.

Max

@FedericoCeratto
Copy link
Contributor

@FedericoCeratto FedericoCeratto commented Jan 12, 2015

@rbrito: coursera-dl is very nice - if you could include this pull request and #303 in the next release I could try to get it packaged in Debian (and its derivatives) :)

This was referenced Apr 15, 2015
@rbrito
Copy link
Member

@rbrito rbrito commented May 6, 2015

Dear Max,

Thank you so very much for this pull request. We now have a setup.py with (at least my changes) inspired on your work.

As a result, I am closing this pull request. I guess that we need an authors file to credit all our contributors...

(A few moments later...)

I have just cherry picked one of your commits and I created an AUTHORS.md file. Feel free to send a pull request with your name, if you'd like.

@rbrito rbrito closed this May 6, 2015
@mshytikov
Copy link
Contributor Author

@mshytikov mshytikov commented May 7, 2015

Waw Guys, you did a great job, congratulation!
Thank you!

Dear @rbrito
Sorry for the late reply I was offline for a long time.
The current setup.py looks much better!
Thank you for your effort you put through to make this happen!

@Make42
Copy link
Contributor

@Make42 Make42 commented Jul 20, 2015

Dear @mshytikov and @rbrito
Is there an installation instruction how to setup the docker besides the posts in #344 ? I get that you somehow integrated the docker into coursera-dl, but how do we take advantage of this?

@mshytikov
Copy link
Contributor Author

@mshytikov mshytikov commented Jul 26, 2015

Dear @Make42

I get that you somehow integrated the docker into coursera-dl, but how do we take advantage of this?

Actually the advantage is small. If you have a proper setup for your python environment then I would say it is better to install coursera via pip pip install coursera.
But in case if you are familiar with docker or you have a problem with using coursera-dl on your machine then you can use docker.

Is there an installation instruction how to setup the docker besides the posts in #344

The Docker installation instruction is OS dependent, please find it here https://docs.docker.com/installation/

For example for me the simplest way is to use Vagrant with docker provisioner.
But in this case you need Vagrant ( and probably VirtualBox ) to be installed on your system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants