New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[false alarm] inconsistent resolve across platform #700

Closed
wisechengyi opened this Issue Nov 28, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@wisechengyi
Copy link
Collaborator

wisechengyi commented Nov 28, 2017

on mac:

$ java -jar ~/Dropbox/Public/coursier-cli.jar resolve -t io.netty:netty-transport-native-epoll:4.1.16.Final 
  Result:
└─ io.netty:netty-transport-native-epoll:4.1.16.Final
   ├─ io.netty:netty-buffer:4.1.16.Final
   │  └─ io.netty:netty-common:4.1.16.Final
   ├─ io.netty:netty-common:4.1.16.Final
   ├─ io.netty:netty-transport:4.1.16.Final
   │  ├─ io.netty:netty-buffer:4.1.16.Final
   │  │  └─ io.netty:netty-common:4.1.16.Final
   │  └─ io.netty:netty-resolver:4.1.16.Final
   │     └─ io.netty:netty-common:4.1.16.Final
   └─ io.netty:netty-transport-native-unix-common:4.1.16.Final
      ├─ io.netty:netty-common:4.1.16.Final
      └─ io.netty:netty-transport:4.1.16.Final
         ├─ io.netty:netty-buffer:4.1.16.Final
         │  └─ io.netty:netty-common:4.1.16.Final
         └─ io.netty:netty-resolver:4.1.16.Final
            └─ io.netty:netty-common:4.1.16.Final

on centos7 and ubuntu 14:

# java -jar coursier-cli.jar  resolve -t io.netty:netty-transport-native-epoll:4.1.16.Final 
  Result:
?? io.netty:netty-transport-native-epoll:4.1.16.Final
   ?? io.netty:netty-buffer:4.1.16.Final
   ?  ?? io.netty:netty-common:4.1.16.Final
   ?? io.netty:netty-common:4.1.16.Final
   ?? io.netty:netty-transport:4.1.16.Final
      ?? io.netty:netty-buffer:4.1.16.Final
      ?  ?? io.netty:netty-common:4.1.16.Final
      ?? io.netty:netty-resolver:4.1.16.Final
         ?? io.netty:netty-common:4.1.16.Final

(weird ?? because of docker)
which misses io.netty:netty-transport-native-unix-common:4.1.16.Final and its deps, and should be fetched according to the pom in https://search.maven.org/#search%7Cga%7C1%7Cnetty-transport-native-epoll-4.1.16

@alexarchambault

This comment has been minimized.

Copy link
Member

alexarchambault commented Nov 29, 2017

Some platform-specific parameters can be used during resolution (these). I haven't looked in detail whether this discrepancy originates from those parameters, but these are the more likely.

@wisechengyi

This comment has been minimized.

Copy link
Collaborator

wisechengyi commented Nov 30, 2017

After looking at it further, coursier might be doing the right thing. The pom contains:

<profile>
  <id>linux</id>
  <activation>
    <os>
      <family>linux</family>
    </os>
  </activation>
  ...
  <dependencies>
    <dependency>
      <groupId>io.netty</groupId>
      <artifactId>netty-transport-native-unix-common</artifactId>
      <version>${project.version}</version>
      <classifier>${jni.classifier}</classifier>
      <!--
        The unix-common with classifier dependency is optional because it is not a runtime dependency, but a build time
        dependency to get the static library which is built directly into the shared library generated by this project.
      -->
      <optional>true</optional>
    </dependency>
  </dependencies>
</profile>

which makes netty-transport-native-unix-common optional on linux.

https://maven.apache.org/pom.html#Activation

@wisechengyi

This comment has been minimized.

Copy link
Collaborator

wisechengyi commented Nov 30, 2017

closed as false alarm

@wisechengyi wisechengyi changed the title [Bug] inconsistent resolve across platform [false alarm] inconsistent resolve across platform Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment