New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[false alarm] parent pom not respected #809

Closed
wisechengyi opened this Issue Mar 12, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@wisechengyi
Copy link
Collaborator

wisechengyi commented Mar 12, 2018

$ resolve -t org.apache.httpcomponents:httpclient:4.2.5
  Result:
└─ org.apache.httpcomponents:httpclient:4.2.5
   ├─ commons-codec:commons-codec:1.6
   ├─ commons-logging:commons-logging:1.1.1
   └─ org.apache.httpcomponents:httpcore:4.2.4

https://search.maven.org/remotecontent?filepath=org/apache/httpcomponents/httpcomponents-client/4.2.5/httpcomponents-client-4.2.5.pom <parent> entry points to https://search.maven.org/remotecontent?filepath=org/apache/httpcomponents/project/6/project-6.pom which has

<modules>
  <module>../httpcore</module>
  <module>../httpclient</module>
  <module>../httpasyncclient</module>
</modules>

so org.apache.httpcomponents:httpcore should also be 4.2.5?

@alexarchambault

This comment has been minimized.

Copy link
Member

alexarchambault commented Mar 12, 2018

<modules> are ignored (I think these are only for local Maven projects). The parent POM sets the version via some dependency management, to ${httpcore.version}, which itself evaluates to 4.2.4 (property set a bit above in the parent POM too).

@wisechengyi

This comment has been minimized.

Copy link
Collaborator

wisechengyi commented Mar 12, 2018

hmm are you referring to

<properties>
  <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
  <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
  <httpcore.version>4.2.4</httpcore.version>
...

then

<dependency>
  <groupId>org.apache.httpcomponents</groupId>
  <artifactId>httpcore</artifactId>
  <version>${httpcore.version}</version>
</dependency>

in https://search.maven.org/remotecontent?filepath=org/apache/httpcomponents/httpcomponents-client/4.2.5/httpcomponents-client-4.2.5.pom?

@alexarchambault

This comment has been minimized.

Copy link
Member

alexarchambault commented Mar 12, 2018

yep

@wisechengyi

This comment has been minimized.

Copy link
Collaborator

wisechengyi commented Mar 12, 2018

Thanks! false alarm then phew...

@wisechengyi wisechengyi changed the title parent pom not respected? [false alarm] parent pom not respected Mar 12, 2018

@baroquebobcat

This comment has been minimized.

Copy link
Contributor

baroquebobcat commented Mar 12, 2018

Thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment