Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix / rework version ordering #1348
First, BuildMetadata will have no effects on version comparison. Next, `+`, `*`, and `x` appearing immediately after dot (`.`) are treated as `max`.
1. Filter out BuildMetadata so they never affect the semantics. 2. Pad the number part so they have the equal digits. This treats 1.0.0 and 1 to be strictly equal, and allows more stable comparison of tags vs other tags.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.