Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / rework version ordering #1348

Merged
merged 3 commits into from Sep 6, 2019

Conversation

@alexarchambault
Copy link
Member

alexarchambault commented Sep 4, 2019

Based on #1315.

Fixes #1313.

eed3si9n added 3 commits Aug 31, 2019
First, BuildMetadata will have no effects on version comparison.

Next, `+`, `*`, and `x` appearing immediately after dot (`.`) are treated as `max`.
1. Filter out BuildMetadata so they never affect the semantics.
2. Pad the number part so they have the equal digits. This treats 1.0.0 and 1 to be strictly equal, and allows more stable comparison of tags vs other tags.
Copy link
Contributor

eed3si9n left a comment

LGTM :)

@alexarchambault

This comment has been minimized.

Copy link
Member Author

alexarchambault commented Sep 6, 2019

Let's merge, thanks for having pushed for it @eed3si9n!

@alexarchambault alexarchambault merged commit 8115b4f into coursier:master Sep 6, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexarchambault alexarchambault deleted the alexarchambault:wip/version branch Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.