New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added acceptense for more possible forms of checksum patterns #640

Merged
merged 2 commits into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@hochgi
Contributor

hochgi commented Aug 16, 2017

Following the message posted on gitter, I modified parseChecksumAlternative to also accept patterns such as:

kafka_2.10-0.10.1.0.tgz: 46A7 8910 F316 32C5 09F8 D540 0ED4 93F1 2479 637B

which can be found on apache's dist repo, e.g:
http://www-eu.apache.org/dist/kafka/0.10.1.0/kafka_2.11-0.10.1.0.tgz.sha1

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Aug 17, 2017

Member

@hochgi Can you add a small unit test for the newly accepted format in ChecksumTests? (A test that would just call parseChecksum.)

Member

alexarchambault commented Aug 17, 2017

@hochgi Can you add a small unit test for the newly accepted format in ChecksumTests? (A test that would just call parseChecksum.)

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Aug 17, 2017

Member

Nice, merging!

Member

alexarchambault commented Aug 17, 2017

Nice, merging!

@alexarchambault alexarchambault merged commit 10c65c6 into coursier:master Aug 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment