New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pants build tool #709

Merged
merged 66 commits into from Dec 11, 2017

Conversation

Projects
None yet
2 participants
@wisechengyi
Collaborator

wisechengyi commented Dec 8, 2017

Per discussion #695

The only code change is at https://github.com/coursier/coursier/pull/709/files#diff-7ca3c74b5087813a533febc6b4a5a7a1R9 as coursier.properties is probably auto generated by sbt. Pants does support build properties but not in this fashion.

The commits are from repurposing other branches, but the actual change is purely declarative.

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Dec 11, 2017

Member

@wisechengyi You shoudn't need to add jackson as a dependency in this PR, do you?

That said, I can merge anyway if you'd like…

Member

alexarchambault commented Dec 11, 2017

@wisechengyi You shoudn't need to add jackson as a dependency in this PR, do you?

That said, I can merge anyway if you'd like…

@wisechengyi

This comment has been minimized.

Show comment
Hide comment
@wisechengyi

wisechengyi Dec 11, 2017

Collaborator

Ah thanks. Forgot to remove it since I was working backwards. Now removed.

Collaborator

wisechengyi commented Dec 11, 2017

Ah thanks. Forgot to remove it since I was working backwards. Now removed.

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Dec 11, 2017

Member

Ok, so merging!

(A bit a pity that pants doesn't call its build files PANTS though…, like buck calls his, BUCK.)

Thanks @wisechengyi !

Member

alexarchambault commented Dec 11, 2017

Ok, so merging!

(A bit a pity that pants doesn't call its build files PANTS though…, like buck calls his, BUCK.)

Thanks @wisechengyi !

@alexarchambault alexarchambault merged commit 1296459 into coursier:master Dec 11, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wisechengyi wisechengyi deleted the wisechengyi:build_only branch Dec 11, 2017

@wisechengyi

This comment has been minimized.

Show comment
Hide comment
@wisechengyi

wisechengyi Dec 11, 2017

Collaborator

haha. actually there has been conversation about converging pants, bazel, and buck to use a common build language called skylark https://github.com/google/skylark. but no nothing immediate yet.

Collaborator

wisechengyi commented Dec 11, 2017

haha. actually there has been conversation about converging pants, bazel, and buck to use a common build language called skylark https://github.com/google/skylark. but no nothing immediate yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment