New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace most of SbtCompatibility with sbt-compat #731

Merged
merged 2 commits into from Jan 10, 2018

Conversation

Projects
None yet
2 participants
@dwijnand
Contributor

dwijnand commented Jan 9, 2018

The sbt-compat version is the latest release from master. I'll cut a stable version if this goes well.

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Jan 9, 2018

Member

Looks cool!

Member

alexarchambault commented Jan 9, 2018

Looks cool!

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Jan 9, 2018

Member

If ever we can't get #730 to work, the current CI failures could be addressed by ensuring the dependency towards sbt-compat is only added if in scala 2.10 or 2.12, like here.

Member

alexarchambault commented Jan 9, 2018

If ever we can't get #730 to work, the current CI failures could be addressed by ensuring the dependency towards sbt-compat is only added if in scala 2.10 or 2.12, like here.

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Jan 9, 2018

Contributor

I don't things will compile without it, but we can try and see.

Contributor

dwijnand commented Jan 9, 2018

I don't things will compile without it, but we can try and see.

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Jan 9, 2018

Member

@dwijnand It should work thanks to

baseDirectory := {
val baseDir = baseDirectory.value
if (sbtScalaVersionMatch.value)
baseDir
else
baseDir / "target" / "dummy"
},
😈

Member

alexarchambault commented Jan 9, 2018

@dwijnand It should work thanks to

baseDirectory := {
val baseDir = baseDirectory.value
if (sbtScalaVersionMatch.value)
baseDir
else
baseDir / "target" / "dummy"
},
😈

dwijnand added some commits Jan 9, 2018

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Jan 10, 2018

Contributor

This went green for both checks. So I published sbt-compat 1.2.0 and switched to that.

Contributor

dwijnand commented Jan 10, 2018

This went green for both checks. So I published sbt-compat 1.2.0 and switched to that.

@alexarchambault

This comment has been minimized.

Show comment
Hide comment
@alexarchambault

alexarchambault Jan 10, 2018

Member

Merging, thanks @dwijnand!

Member

alexarchambault commented Jan 10, 2018

Merging, thanks @dwijnand!

@alexarchambault alexarchambault merged commit 1bb7742 into coursier:master Jan 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand deleted the dwijnand:sbt-compat branch Jan 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment