New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluggable loggers for sbt-coursier #872

Merged
merged 5 commits into from Jun 29, 2018

Conversation

Projects
None yet
2 participants
@teozkr
Contributor

teozkr commented Jun 16, 2018

This change allows you to set coursierLoggerFactory to any Cache.Logger you wish. I'm planning to use this for sbt-lockfile, but this also fixes #363 (by letting you set it to a no-op logger).

@alexarchambault

This comment has been minimized.

Member

alexarchambault commented Jun 20, 2018

Thanks @teozkr. I wonder if this could be tested via a scripted test (those are under this directory). The test could set up its own logger, run an update, and check that a few methods on the logger are actually called (init, …). Is it something you would feel like adding? I can look into it else…

@alexarchambault

This comment has been minimized.

Member

alexarchambault commented Jun 29, 2018

Merging, thanks!

@alexarchambault alexarchambault merged commit 0b187ef into coursier:master Jun 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@teozkr

This comment has been minimized.

Contributor

teozkr commented Jul 4, 2018

Thanks! Any idea when the next milestone is happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment