Introduce Scalafmt via Pants #877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisechengyi
changed the title
|
@wisechengyi I'm not sure I want to add this right now, as the sources of coursier aren't formatted by scalafmt for now… But it sure should be merged as soon as it's added. |
|
This PR has no effect until pants lint is used in Travis. But yeah, whenever you feel comfortable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces scalafmt as an automated formatter and linter via Pants.
To format:
To lint (which would run in CI):
Example changes are visible at: https://github.com/coursier/coursier/compare/master...wisechengyi:eg?expand=1
A separate PR would be made once this gets in to format all targets covered by Pants and to enforce it via CI.