New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to follow HTTP -> HTTPS redirections #976

Merged
merged 2 commits into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@alexarchambault
Member

alexarchambault commented Nov 29, 2018

Disabled by default in the API, not to run into possible security issues (https://stackoverflow.com/a/1884427/3714539). Pass followHttpToHttpsRedirections = true to Cache.fetch and Cache.file to enable it.

Enabled by default in the command-line (less likely a custom authenticator was set up there).

Allow to follow HTTP -> HTTPS redirections
Disabled by default in the API, not to run into possible
security issues (https://stackoverflow.com/a/1884427/3714539).
Pass `followHttpToHttpsRedirections = true` to Cache.fetch and
Cache.file to enable it

Enabled by default in the command-line (less likely a custom
authenticator was set up there).
@alexarchambault

This comment has been minimized.

Member

alexarchambault commented Nov 29, 2018

Should fix #889.

@jvican

jvican approved these changes Nov 29, 2018

LGTM, no comments to add 👍

@alexarchambault alexarchambault force-pushed the topic/http-https-redirect branch from 02ace2d to 1cb43de Nov 30, 2018

Disable redirection tests on Appveyor
Too cumbersome to launch an extra side server there…

@alexarchambault alexarchambault force-pushed the topic/http-https-redirect branch from 1cb43de to 44b3435 Nov 30, 2018

@alexarchambault alexarchambault merged commit 9962a41 into master Nov 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alexarchambault alexarchambault deleted the topic/http-https-redirect branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment