Skip to content

Allow linking flags to be passed through LDFLAGS environment variable - #981

Merged
alexarchambault merged 3 commits into
coursier:masterfrom
jgogstad:lookup_ldflags
Dec 3, 2018
Merged

alexarchambault merged 3 commits into
coursier:masterfrom
jgogstad:lookup_ldflags

Conversation

@jgogstad

@jgogstad jgogstad commented Dec 2, 2018

Copy link
Copy Markdown
Contributor

Allow the user to specify linking flags through LDFLAGS when creating native bootstraps.

This allows for instance for linking applications that uses STTP for Scala Native (requires LDFLAGS=-L/usr/local/opt/curl/lib, see sttp#Building & testing the scala-native backend)

Comment thread modules/extra/src/main/scala-2.12/coursier/extra/Native.scala Outdated
@alexarchambault

Copy link
Copy Markdown
Member

Thanks @jgogstad! Added a small comment.

Co-Authored-By: jgogstad <jostein.gogstad@gmail.com>
@jgogstad

jgogstad commented Dec 3, 2018

Copy link
Copy Markdown
Contributor Author

It would indeed be simpler, thanks

@alexarchambault
alexarchambault merged commit 07cd451 into coursier:master Dec 3, 2018
@alexarchambault

Copy link
Copy Markdown
Member

Merged, thanks!

@jgogstad

Copy link
Copy Markdown
Contributor Author

Any chance to include this on 1.1.0? I was hoping to demo @pcejrowski's STTP client for a CLI published with homebrew and linked on the client's localhost with coursier.

@alexarchambault

Copy link
Copy Markdown
Member

@jgogstad This is included in 1.1.0-M10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants