Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linking flags to be passed through LDFLAGS environment variable #981

Merged
merged 3 commits into from Dec 3, 2018

Conversation

@jgogstad
Copy link
Contributor

@jgogstad jgogstad commented Dec 2, 2018

Allow the user to specify linking flags through LDFLAGS when creating native bootstraps.

This allows for instance for linking applications that uses STTP for Scala Native (requires LDFLAGS=-L/usr/local/opt/curl/lib, see sttp#Building & testing the scala-native backend)

@alexarchambault
Copy link
Member

@alexarchambault alexarchambault commented Dec 3, 2018

Thanks @jgogstad! Added a small comment.

Co-Authored-By: jgogstad <jostein.gogstad@gmail.com>
@jgogstad
Copy link
Contributor Author

@jgogstad jgogstad commented Dec 3, 2018

It would indeed be simpler, thanks

@alexarchambault alexarchambault merged commit 07cd451 into coursier:master Dec 3, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexarchambault
Copy link
Member

@alexarchambault alexarchambault commented Dec 3, 2018

Merged, thanks!

@jgogstad
Copy link
Contributor Author

@jgogstad jgogstad commented Jan 13, 2019

Any chance to include this on 1.1.0? I was hoping to demo @pcejrowski's STTP client for a CLI published with homebrew and linked on the client's localhost with coursier.

@alexarchambault
Copy link
Member

@alexarchambault alexarchambault commented Jan 16, 2019

@jgogstad This is included in 1.1.0-M10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants