Skip to content

Add LICENSE file #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

martinling
Copy link

Hi @courvoif,

We've been using your pcap-file crate in Packetry and we're very happy with it. As part of our release preparations, I've been going through the license requirements for all of our dependencies, including byteorder_slice.

Currently byteorder_slice declares an MIT license type in Cargo.toml, but there's no license file in the repository, nor in its released crates.

The terms of the MIT license require us to include both your original copyright notice, and the original license text, when we distribute our program. Because these are missing we can't technically comply with that requirement.

This PR adds the necessary LICENSE file, using the same text as the one you have for pcap-file. I have set the copyright dates based on the commits in this repository.

@vlrpl
Copy link

vlrpl commented Aug 7, 2024

We are currently in the process of packaging our tool, Retis, for Fedora, which depends on pcap-file.

Since both byteorder_slice and pcap-file are not yet part of Fedora, we have submitted a review request to package them.

The MIT license requires that redistributed sources contain a copy of the license text. This also applies to crates distributed via crates.io and packages for linux distros.
For this reason, we're interested in this PR and that the license text is included in a published crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants