Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css,color-dot): add margin top & bottom auto for center the dot #2070

Closed
wants to merge 1 commit into from

Conversation

toofff
Copy link
Member

@toofff toofff commented Jun 30, 2021

Proposed Changes

Currently the point is not centered. This allows it to be centered vertically.

Potential Breaking Changes

Acceptance Criteria

  • The proposed changes are covered by unit tests
  • The potential breaking changes are clearly identified
  • README.md is adjusted to reflect the proposed changes (if relevant)

@toofff toofff requested a review from a team as a code owner June 30, 2021 20:00
@toofff toofff requested review from gdostie, dmgauthier and sallainCoveo and removed request for a team June 30, 2021 20:00
Copy link

@coveobot coveobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -7,6 +7,7 @@
min-width: var(--size);
height: var(--size);
min-height: var(--size);
margin: auto 0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand this change. I seems that with the suggested solution, the color dot is lower than what we had before.

Problem reported

image

Suggested solution

image

Before (without margin: auto 0;)

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work is only part of the solution, the rest is done in the UI admin and it is nearing completion.

I should have put this PR in draft, a thousand excuses

@toofff toofff marked this pull request as draft July 1, 2021 02:23
@toofff toofff closed this Jul 3, 2021
@toofff toofff deleted the feature/ADUI-7272 branch July 3, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants