Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverlet.collector format: possible to specify without runsettings file? #563

Closed
escalonn opened this issue Sep 23, 2019 · 6 comments · Fixed by #873
Closed

coverlet.collector format: possible to specify without runsettings file? #563

escalonn opened this issue Sep 23, 2019 · 6 comments · Fixed by #873
Labels
documentation question This issue is a question up-for-grabs Good issue for contributors

Comments

@escalonn
Copy link

@escalonn escalonn commented Sep 23, 2019

This section of the docs suggests that it's possible to set the Format option without needing a runsettings file. (Possibly with a runsettings command line argument after -- ?)

If so, provide an example.

If not, please clarify in the docs that changing any options, including format, requires a runsettings file. (If true, this is pretty obnoxious compared to the way it works with MSBuild integration.)

@MarcoRossignoli MarcoRossignoli added question This issue is a question documentation up-for-grabs Good issue for contributors labels Sep 23, 2019
@MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Sep 23, 2019

This section of the docs suggests that it's possible to set the Format option without needing a runsettings file.

Sorry @escalonn maybe the guide is not clear...we mean that the format parameter is the only "default" parameter passed and the default format is cobertura(https://github.com/tonerdo/coverlet/blob/master/src/coverlet.collector/Utilities/CoverletConstants.cs#L8).
We should improve that part of documetation. Feel free to offer a PR if you want.

If not, please clarify in the docs that changing any options, including format, requires a runsettings file. (If true, this is pretty obnoxious compared to the way it works with MSBuild integration.)

I agree with you users experience with runsettings is not so great.
We talked a bit in past with vstest team(on our side we cannot do nothing for it) cc: @vagisha-nidhi to understand if there are plan by vstest team to improve user experience.

@ItsVeryWindy
Copy link

@ItsVeryWindy ItsVeryWindy commented Jun 5, 2020

In case anyone wants to know, It is possible to set the format although it's a bit long winded, for example.

DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=opencover

@MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Jun 5, 2020

Oh, sorry I misunderstood the question...every parameters inside runsettings can be specified by using xml flat syntax, I meant that there is no -- style parameters for collectors parameters.

@ItsVeryWindy thanks for your addition!

@escalonn
Copy link
Author

@escalonn escalonn commented Jun 5, 2020

In case anyone wants to know, It is possible to set the format although it's a bit long winded, for example.

DataCollectionRunSettings.DataCollectors.DataCollector.Configuration.Format=opencover

That's exactly what I was looking for. Thanks

@tremblaysimon
Copy link

@tremblaysimon tremblaysimon commented Jun 5, 2020

Really interesting! I think it should be officially documented if it's not already.

@MarcoRossignoli
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli commented Jun 5, 2020

Asap I'll add documentation on it, not the best way but better than nothing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation question This issue is a question up-for-grabs Good issue for contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants