IC2 Consumers need to be replaced on unload #28

sameer · 2016-01-12T02:37:57Z

@covers1624
This problem is using the latest PR of PowerConverters on curse. If you need pictures I can try to get some.

When a chunk is unloaded, the IC2 consumer connected to an energy bridge stops working. Even if wires are replaced, it simply does not start working. The energy bridge recognizes that the IC2 consumer is there and has 100% internal charge, but it just doesn't convert. Upon replacing the consumer with no other changes, the setup starts working again.
Players using the HV consumer have reported this to me.

I know some basic Forge Java but I haven't looked into the code of PowerConverters much, any idea what this might be caused by?

covers1624 · 2016-01-12T05:08:58Z

Ill speak to the owner of IC2 Classic and see what he says.

sameer · 2016-01-12T13:30:57Z

@covers1624 awesome.

sameer · 2016-01-12T23:24:19Z

Any update?

covers1624 · 2016-01-13T00:41:55Z

Not yet unfortunately, @Speiger needs to get on TS xD

sameer · 2016-01-13T00:43:42Z

Which TS? 😛 I would like to join.

Speiger · 2016-01-13T11:57:42Z

@robotia which Ic2 Classic version do you use?
If you are using below the latest (1.1.3.7) then it is because you did not use the version where it is fixed...
(Its a chunkUnload/blockUpdate thingy)

sameer · 2016-01-13T14:58:20Z

I cannibalized the files from the latest so I could merge it with 1.1.3.5. I replaced everything except the IC2 main class and never added PE integration.

Speiger · 2016-01-13T16:01:30Z

@robotia just delete the PEIntegration folder and everything is fine.
Every folder that is a Intigration/Integration can be deleted without causing a crash...
But 1.1.3.7 is a important fix....

sameer · 2016-01-13T16:22:48Z

@Speiger I didn't want the client-side version to have to change so I applied the diffs only server-side.

I moved the following files from the v1.1.3.7 jar to the v.1.1.3.5 jar:
TileEntityGeoGenerator
TileEntitySolarGenerator
BlockElectric
StackUtil

I didn't change the actual IC2 class, could that be causing problems?

Speiger · 2016-01-14T03:48:09Z

@robotia you know when you play on a server that the client gets the server sided EMC Values right?
So no Plugin no EMC Values... And no there are a lot more changes then these classes...
So just throw the IC2 1.1.3.7 on your server where the EMC Plugin is missed and you will have no problems...

Edit: You try to fix it with copying some classes will not solve it... It will cause maybe even more problems...
The classes you have to move to make it happen (only classes at least for the cable dissconnecting bugs) are all EnergyNet Classes (the whole folder)
but again i do not take any responsibility for problems if you do that... Because that can cause anything... So keep that in mind.....

sameer · 2016-01-14T03:53:24Z

@Speiger already merged everything except PE integration with no problems. These producers were my only worry. @covers1624 do you use QmunityLib?

covers1624 · 2016-01-14T06:16:42Z

@robotia I do not use Qmunity Lib, and try this build: http://adel.podgeweb.com:8080/job/Power%20Converters/116/

sameer · 2016-01-14T20:40:01Z

@covers1624 Thanks I will try it out.

sameer · 2016-01-15T01:31:05Z

@covers1624 Doesn't work. New problems have come up.
java.lang.ArrayIndexOutOfBoundsException: -1 at covers1624.powerconverters.tile.ic2.TileEntityIndustrialCraftProducer.getMaxEnergyOutput(TileEntityIndustrialCraftProducer.java:78) at covers1624.powerconverters.tile.ic2.TileEntityIndustrialCraftProducer.getOfferedEnergy(TileEntityIndustrialCraftProducer.java:88) at ic2.core.energy.EnergyNetLocal.onTickEnd(EnergyNetLocal.java:802) at ic2.core.energy.EnergyNetGlobal.onTickEnd(EnergyNetGlobal.java:163) at ic2.core.IC2.onTickEnd(IC2.java:2097) at ic2.core.IC2.onWorldTick(IC2.java:1993) at cpw.mods.fml.common.eventhandler.ASMEventHandler_42_IC2_onWorldTick_WorldTickEvent.invoke(.dynamic) at cpw.mods.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:54) at cpw.mods.fml.common.eventhandler.EventBus.post(EventBus.java:140) at cpw.mods.fml.common.FMLCommonHandler.onPostWorldTick(FMLCommonHandler.java:259) at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:974) at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:431) at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:809) at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:669) at java.lang.Thread.run(Thread.java:745)

sameer · 2016-01-15T01:39:47Z

@covers1624 I think something's up with the NBT, I reverted and the crash is still occurring. Going to edit the code and catch the exception to return 0.

sameer · 2016-01-15T04:47:08Z

@covers1624 The update messed up getPowerSystem().getVoltageValues(). I have custom put in those values now.

covers1624 · 2016-01-15T07:37:00Z

i have added checks in the code for this issue, yeah the nbt was broken, try this one http://adel.podgeweb.com:8080/job/Power%20Converters/117/

sameer · 2016-01-16T02:42:17Z

@covers1624 Spam of [21:40:39 ERROR]: Tile IC2Producer at { X,Y,Z;UNKNOWN} needs to be replaced!. IC2 Producers work but don't show up as linked the converter gui. I'm just going to hold onto what I had earlier and not worry about this I guess, instead just make something that auto-replaces them on chunk load.

covers1624 · 2016-01-16T11:54:22Z

Did you replace the block? that would have fixed it.

sameer · 2016-01-16T13:49:07Z

@covers1624 I was at a different location, that was not my setup. Someone else's setup was having problems. :/

My power converter setup just didn't allow the IC2 producers to link up in the GUI.

sameer · 2016-02-07T04:10:54Z

@covers1624 Are you on IRC?

covers1624 · 2016-02-07T06:29:16Z

sure am #PowerConverters or #LegacyFarms

gromovjm · 2016-07-03T12:33:17Z

I am using the latest version of the changes that appear in the image.
And note that the problem is again in IC2 producer
I do not know who IC2. or PowerConverters, but one of them remembers its position in the world.
And install it in the same place, nothing happens.
And if you change your position, the result will be successful.

The unit recorded a producer who was in the wrong place.
After reload, the chunk was rearranged to another place.

Speiger · 2016-07-03T20:00:28Z

@Magicfar4 is that IC2 Exp 1.9-1.10? If yes then this is a normal bug because the current dev of the energynet has not understood the mistakes he did on it...

gromovjm · 2016-07-03T21:59:17Z

@Speiger , No. My version is: "version": "2.2.817-experimental".

Speiger · 2016-07-03T22:28:47Z

@Magicfar4 was at the place where the 1 is a IC2 Producer or Consumer?
If yes then @covers1624 does the unloading wrong because the energynet still thinks: there is a Target/Source and the cables show what the energynet thinks...

Edit: But as i know covers he will say it: "I will fix it in 1.9 or 1.10" or "IC2s EnergyNet is broken so its not my problem"

gromovjm · 2016-07-04T06:40:51Z

Yes , the place was a producer .

I will hope that the problem will be correcting ...

Speiger · 2016-07-04T07:18:20Z

well while reading his source i found a couple small bugs in the code (mostly lazyness bugs) but nothing that could cause that... Does that happening all the time or randomly @Magicfar4
Also just a question: Do you play on a server or client only? There are random cases where that actually can happen...

Speiger · 2016-07-04T07:19:32Z

Also do not think in 1.7.10 that will be fixed on either side. IC2 Exp dropped 1.7.10 same goes this mod and its owner... And to let a quality version behind is not a priority just to be up to date...

gromovjm · 2016-07-04T07:25:59Z

@Speiger , with this modification check is performed on the server and in a single game.
And I think that if you put it on the server , where I play , then work it never will :(

Speiger · 2016-07-04T08:43:25Z

(thats why i made my own internal converters) to not rely on something like that and still have compat xD

gromovjm · 2016-07-04T08:51:08Z

@Speiger , its internal converters ; )
Tempting ... I would like a little more knowledge of modding and he would have done ...

Obliterous · 2016-10-05T03:12:51Z

So, this is not going to be fixed?

covers1624 · 2016-10-05T04:46:57Z

If i ever do another 1.7 round yes. Otherwise it will be fixed in 1.10. At this point 1.7 is basically dead so i see no reason to support it, i have moved on to 1.10 and apart from critical fixes (i.e break your server issues) i wont support 1.7.

Speiger · 2016-10-05T05:11:18Z

1.7.10 has more then enough people on that version (and proberly will have it longer then 1.1x) to support it... I suggest to fix it.

Obliterous · 2016-10-05T07:46:54Z

considering that most of the mods that my server uses do not support
1.1x, myself and all of my players will stick to 1.7.10.

On 10/4/2016 10:11 PM, Speiger wrote:

1.7.10 has more then enough people on that version (and proberly will
have it longer then 1.1x) to support it... I suggest to fix it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAL6l-3wneeVjQ6rC5QXN_1QkB03RGa9ks5qwzF2gaJpZM4HC04p.

IC2 Consumers need to be replaced on unload #28

IC2 Consumers need to be replaced on unload #28

Comments

sameer commented Jan 12, 2016

covers1624 commented Jan 12, 2016

sameer commented Jan 12, 2016

sameer commented Jan 12, 2016

covers1624 commented Jan 13, 2016

sameer commented Jan 13, 2016

Speiger commented Jan 13, 2016

sameer commented Jan 13, 2016

Speiger commented Jan 13, 2016

sameer commented Jan 13, 2016

Speiger commented Jan 14, 2016

sameer commented Jan 14, 2016

covers1624 commented Jan 14, 2016

sameer commented Jan 14, 2016

sameer commented Jan 15, 2016

sameer commented Jan 15, 2016

sameer commented Jan 15, 2016

covers1624 commented Jan 15, 2016

sameer commented Jan 16, 2016

covers1624 commented Jan 16, 2016

sameer commented Jan 16, 2016

sameer commented Feb 7, 2016

covers1624 commented Feb 7, 2016

gromovjm commented Jul 3, 2016 • edited

Speiger commented Jul 3, 2016

gromovjm commented Jul 3, 2016 • edited

Speiger commented Jul 3, 2016 • edited

gromovjm commented Jul 4, 2016

Speiger commented Jul 4, 2016

Speiger commented Jul 4, 2016 • edited

gromovjm commented Jul 4, 2016

Speiger commented Jul 4, 2016

gromovjm commented Jul 4, 2016

Obliterous commented Oct 5, 2016

covers1624 commented Oct 5, 2016

Speiger commented Oct 5, 2016 • edited by covers1624

Obliterous commented Oct 5, 2016

gromovjm commented Jul 3, 2016 •

edited

gromovjm commented Jul 3, 2016 •

edited

Speiger commented Jul 3, 2016 •

edited

Speiger commented Jul 4, 2016 •

edited

Speiger commented Oct 5, 2016 •

edited by covers1624