Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Add ESLint and prettier #173
szhu left a comment •
+1 to this change, I was thinking of adding something similar.
But, just because you've run it on all the files doesn't mean that future contributors will run it on code they add, since things will just get messy again over time. (I know that there are editor integrations that devs can set up, but it's hard to tell everyone to use them.)
I think we should do the following before merging this PR:
Good call -- added the pre-commit hook.
I don't have access to the CI server/Netlify, so it's hard to set up a lint check (I can't see the logs when checks are failing). Do you know who could give me access?
If I can get CI access and verify the checks there, I think this will be good to go.