GCC 4.8 introduces a warning for unused typedefs, which libv8 triggers,
so we need to turn off error-on-warnings (werror).
This is for the master branch. 3.11 is in another pull request.
Although it would decrease compilation failures, I think it would be best to limit the addition of this flag only to GCC 4.8.
Having seen http://code.google.com/p/v8/issues/detail?id=2149, I think we should take 4.8 out of the supported compilers and add unless check_gcc_compiler(compiler).
Updated. I didn't go for actually removing 4.8 from the supported compilers, as it seemed like supporting the alternate BSD names (like "g++48") would get quite hacky. It would be easy enough to put a warning in either here or in compiler.rb, though.
I'm not sure what that warning should be. The issue with disabling werror, as I see it, is that there is a higher possibility that a problem with the build environment (and libv8's assumptions about the system libraries in particular) could go unnoticed, and as a result a buggy binary be built.
Fix build with GCC 4.8