From 9f834a9b77bee43b54df8293927bf5e92d832633 Mon Sep 17 00:00:00 2001 From: fafk Date: Fri, 10 Oct 2025 14:13:18 +0200 Subject: [PATCH 1/3] Don't use unsafe default balancer address --- src/deploy/002_settlement.ts | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/deploy/002_settlement.ts b/src/deploy/002_settlement.ts index 33d1c326..d53bbed8 100644 --- a/src/deploy/002_settlement.ts +++ b/src/deploy/002_settlement.ts @@ -7,8 +7,6 @@ import Vault from "../../balancer/Vault.json"; import BALANCER_NETWORKS from "../../balancer/networks.json"; import { CONTRACT_NAMES, SALT } from "../ts/deploy"; -const DEFAULT_VAULT_ADDRESS = "0xBA12222222228d8Ba445958a75a0704d566BF2C8"; - const deploySettlement: DeployFunction = async function ({ deployments, ethers, @@ -48,13 +46,10 @@ const deploySettlement: DeployFunction = async function ({ >; const vaultDeployment = vaultNetworks[chainId]; if (vaultDeployment === undefined) { - console.warn( - `Vault not deployed on chain ${chainId}, using default address.`, - ); - vaultAddress = DEFAULT_VAULT_ADDRESS; - } else { - vaultAddress = vaultDeployment.address; + throw new Error(`Vault not deployed on chain ${chainId}. Get the balancer address from the balancer team and add it to the networks.json file`); } + + vaultAddress = vaultDeployment.address; } await deploy(settlement, { From 216a12c175d89e5c4b9c2064a706407bb959429d Mon Sep 17 00:00:00 2001 From: fafk Date: Fri, 10 Oct 2025 14:20:27 +0200 Subject: [PATCH 2/3] Fix lint --- src/deploy/002_settlement.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/deploy/002_settlement.ts b/src/deploy/002_settlement.ts index d53bbed8..8145a2a2 100644 --- a/src/deploy/002_settlement.ts +++ b/src/deploy/002_settlement.ts @@ -46,7 +46,9 @@ const deploySettlement: DeployFunction = async function ({ >; const vaultDeployment = vaultNetworks[chainId]; if (vaultDeployment === undefined) { - throw new Error(`Vault not deployed on chain ${chainId}. Get the balancer address from the balancer team and add it to the networks.json file`); + throw new Error( + `Vault not deployed on chain ${chainId}. Get the balancer address from the balancer team and add it to the networks.json file`, + ); } vaultAddress = vaultDeployment.address; From d2cb0376ca198bfce8ec692bee50b88705557149 Mon Sep 17 00:00:00 2001 From: "Jan [Yann]" <4518474+fafk@users.noreply.github.com> Date: Thu, 30 Oct 2025 13:40:48 +0100 Subject: [PATCH 3/3] Apply suggestion from @fedgiac Co-authored-by: Federico Giacon <58218759+fedgiac@users.noreply.github.com> --- src/deploy/002_settlement.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/deploy/002_settlement.ts b/src/deploy/002_settlement.ts index 8145a2a2..d5a8b4fb 100644 --- a/src/deploy/002_settlement.ts +++ b/src/deploy/002_settlement.ts @@ -47,7 +47,7 @@ const deploySettlement: DeployFunction = async function ({ const vaultDeployment = vaultNetworks[chainId]; if (vaultDeployment === undefined) { throw new Error( - `Vault not deployed on chain ${chainId}. Get the balancer address from the balancer team and add it to the networks.json file`, + `Vault not validated on chain ${chainId}. Make sure the Balancer deployment is safe to use first, then add it to the networks.json file`, ); }