feat: use new wrapper from upstream #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedgiac
reviewed
Sep 29, 2025
Contributor
There was a problem hiding this comment.
What's this binary blob about?
Collaborator
Author
There was a problem hiding this comment.
I think it comes from my editor :/ it gets automatically added to all my projects. but yes it shouldnt be here
This reverts commit e56eac3.
Merged
fedgiac
reviewed
Sep 29, 2025
| GPv2Interaction.Data[][3] calldata interactions | ||
| ) external payable { | ||
| if (msg.sender != address(EVC)) { | ||
| revert Unauthorized(msg.sender); |
Contributor
There was a problem hiding this comment.
The assumption here is that the EVC is fully trusted to forward this call without changing the parameters. Is this true?
In general I'd expect that the code checks that the settlement data used in evcInternalSettle matches the one that _wrap wants to forward to it (and also that it's called exactly once).
With the current code, the EVC contract can execute any settlement it wants once wrappedSettle is called.
best way to ensure the expected flow is followed exactly
This was referenced Nov 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the generic wrappers implementation has changed upstream. Modifications to use this new pattern.