Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mishandled angle brackets in message text #411

Closed
bfix opened this Issue Dec 16, 2016 · 9 comments

Comments

4 participants
@bfix
Copy link

bfix commented Dec 16, 2016

If an outgoing message contains an angle bracket pair "<...>" like a markup tag, only the text before the pair is received on the other end.

@olabini

This comment has been minimized.

Copy link
Contributor

olabini commented Dec 17, 2016

Hi,

I can't reproduce this. I sent hallo <foo> bar and received exactly the same thing on the other side. Can you specify what you're doing to make this behavior happen?

@bfix

This comment has been minimized.

Copy link
Author

bfix commented Dec 17, 2016

i happened reproducable in a conversation with a pidgin client on the other side.

@olabini

This comment has been minimized.

Copy link
Contributor

olabini commented Dec 17, 2016

This only happens when you have an OTR conversation going. Pidgin handles it correctly without OTR.

@olabini

This comment has been minimized.

Copy link
Contributor

olabini commented Dec 17, 2016

OK, so the behavior here is highly idiosyncratic and different inbetween different implementations. For example, Pidgin when sending will escape most html looking things, unless it's well formed style elements such as the "i" tag. However, if you have OTR turned on, EVERYTHING html looking will be escaped. Gajim seems to do the same thing.

It's not exactly clear what the right behavior here is.

Incidentally, I can't reproduce the behavior you are seeing. If I send hello <foo> bar Pidgin will show me hello bar - obviously not great, but it's different from the behavior you mentioned.

@bfix

This comment has been minimized.

Copy link
Author

bfix commented Dec 17, 2016

sorry, i was unprecise in my first message, should have read: "... only the text around the pair is received..."

@bfix

This comment has been minimized.

Copy link
Author

bfix commented Dec 17, 2016

so escaping sgml text (at least in otr) is not an option for coyim?

@olabini

This comment has been minimized.

Copy link
Contributor

olabini commented Dec 17, 2016

Escaping HTML is absolutely possible, and indeed something we already do. The problem is how we escape and when. And since Pidgin and Gajim and the others seem to do different things at different points, and that this differs depending on if an OTR conversation is active or not, it's a bit hard to figure out what behavior is the correct one.

@0x27

This comment has been minimized.

Copy link

0x27 commented Apr 17, 2017

Ran into this same issue, kind of. When I send messages containing "<", everything after the "<" doesn't display Coyim side, but seems to display fine on my recipients side. Super annoying for pasting shell oneliners in chat to people...

Edit: Should note that this is during an OTR conversation.

@juniorz juniorz added this to the 0.4.0 Release milestone Nov 7, 2017

@juniorz juniorz added this to to do in Next release Nov 10, 2017

@juniorz juniorz removed this from to do in Next release Nov 10, 2017

@juniorz juniorz added this to to do in Next release Nov 10, 2017

@olabini

This comment has been minimized.

Copy link
Contributor

olabini commented Aug 20, 2018

The current behavior is that the angle brackets will be quoted as is, inside an OTR conversation. I'm fine with that. Hope that works for everyone.

@olabini olabini closed this Aug 20, 2018

@claucece claucece moved this from to do to done in Next release Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.