Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly render errors when adding account #445

Closed
claucece opened this Issue Sep 25, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@claucece
Copy link
Member

claucece commented Sep 25, 2017

There are three errors that can show up when adding an account:

  1. Cannot add account if account field is missing.
  2. XMPP address has an invalid domain part. An XMPP address should look like this: local@domain.com.
  3. XMPP address has an invalid local part. An XMPP address should look like this: local@domain.com.

Currently, error 1 with any of the other errors will stack rather than replace the notification.

screen shot 2017-09-25 at 11 13 35 am

Error 2 and error 3 will not replace themselves nor stack. For example, if an user forgets to add the local part, error 3 will show. If he then forgets to add the domain part, error 3 will still be there and will not be replaced by error 2.

Expected behavior: errors should replace themselves or there should be only one error, such as "invalid credentials".

claucece added a commit that referenced this issue Oct 7, 2017

@claucece claucece closed this Oct 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.