Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Windows installer #522

Closed
olabini opened this issue Mar 8, 2019 · 4 comments
Closed

Create Windows installer #522

olabini opened this issue Mar 8, 2019 · 4 comments
Assignees
@olabiniV2
Labels
distribution feature Priority: Now release engineering Release State: Doing This story is currently in development windows
Milestone
0.4 Release

Comments

@olabini
Copy link
Contributor

olabini commented Mar 8, 2019

It would nice to have an installer for the Windows build - we can use https://nsis.sourceforge.io/Main_Page for this.
@Cris2760 Cris2760 added this to todo in MUC Aug 20, 2019
@olabiniV2 olabiniV2 removed this from todo in MUC Jun 2, 2020
@olabiniV2 olabiniV2 self-assigned this Feb 9, 2021
@olabiniV2
Copy link
Contributor

There seems to exists at least 3 different tools that might be possible to use. msitools, nsis and Inno Setup. Of these, nsis is the only one available for msys2. I'm not a 100% clear but it seems msitools is actually something that runs in a Linux system for building MSIs. It would be possible for us to use Inno Setup since it's available in Chocolaty (a package manager for Windows, which Travis and Github Actions both support, I seem to remember). You can install it on windows simply doing choco install InnoSetup

For now, my suggestion is that we investigate NSIS first, as a solution to this issue.

@olabiniV2
Copy link
Contributor

It seems msitools doesn't support creating an installer UI, something that we definitely would want.

@olabiniV2
Copy link
Contributor

We could likely use something like this: https://nsis.sourceforge.io/Sample_installation_script_for_an_application as inspiration for our installer.

@olabiniV2 olabiniV2 added this to the 0.4 Release milestone Feb 10, 2021
@olabiniV2 olabiniV2 mentioned this issue Feb 10, 2021
Open
@olabiniV2 olabiniV2 added Priority: Now State: Doing This story is currently in development labels Feb 19, 2021
olabiniV2 pushed a commit that referenced this issue Feb 19, 2021
@olabini
Part of #522. Add the definition for the NSIS installer, add an icon …
eecee16 
…in Windows format, and a syso file that embeds the icon file as well, to make it available to the .exe
olabiniV2 pushed a commit that referenced this issue Feb 19, 2021
@olabini
Part of #522, #694. Add support for building Windows release and inst…
b243695 
…aller.
olabiniV2 pushed a commit that referenced this issue Feb 19, 2021
@olabini
Part of #522 - I need to specify windows paths correctly...
a57694d
@olabiniV2
Copy link
Contributor

This is done. We have a basic NSIS installer which publishes automatically just as the other releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olabiniV2 olabiniV2

Labels
distribution feature Priority: Now release engineering Release State: Doing This story is currently in development windows
Projects
None yet
Milestone
0.4 Release
Development

No branches or pull requests
3 participants
@olabini @claucece @olabiniV2