Add cozy mobile build :tada: #16

Merged
merged 7 commits into from Jan 11, 2017

Projects

None yet

4 participants

@kosssi
Contributor
kosssi commented Jan 6, 2017 edited
  • Add specific .gitignore
  • Add new page only on mobile
  • Update build
  • Add documentation to mobile part
  • Add Android build on Travis
  • Mutualise mobile main.jsx and front main.jsx
@kosssi kosssi changed the title from [WIP] Add cozy mobile build :tada: to Add cozy mobile build :tada: Jan 10, 2017
@kosssi kosssi self-assigned this Jan 10, 2017
@kosssi kosssi requested review from enguerran and m4dz Jan 10, 2017
@enguerran

I suggest we change the default config.xml content:

  • name
  • description
  • author
@enguerran

I don't like the dependency change in package.json, see below.

package.json
@@ -77,7 +79,7 @@
"dependencies": {
"babel-preset-es2015": "^6.18.0",
"classnames": "^2.2.0",
- "cozy-client-js": "^0.0.1",
+ "cozy-client-js": "https://github.com/cozy/cozy-client-js.git#99b935bff6b3c3b83c58ea0f975b90a13a44c570",
@enguerran
enguerran Jan 10, 2017 Contributor

I don't like this. We need to publish the correct dependency on npm and maybe add a note in the README.md to explain a workaround if needed.

yarn.lock
@@ -1336,9 +1336,9 @@ cosmiconfig@^2.1.0, cosmiconfig@^2.1.1:
parse-json "^2.2.0"
require-from-string "^1.1.0"
-cozy-client-js@^0.0.1:
+"cozy-client-js@https://github.com/cozy/cozy-client-js.git#99b935bff6b3c3b83c58ea0f975b90a13a44c570":
@enguerran
enguerran Jan 10, 2017 Contributor

cf comment in package.json

@m4dz

Nice! I add some extra reviewers for components that it didn't touch myself. Thanks 👍

config/webpack.base.config.js
output: {
- path: path.resolve(__dirname, '../build'),
+ path: path.resolve(__dirname, '../' + outputFolder),
@m4dz
m4dz Jan 10, 2017 Member

Better if written path.resolve(__dirname, '..', outputFolder), nope?

@kosssi
kosssi Jan 10, 2017 Contributor

done

config/webpack.hash.config.js
module.exports = {
plugins: [
// Extracts Hash in external file for reference
function () {
this.plugin('done', (stats) => {
fs.writeFileSync(
- path.join(__dirname, '../build/assets.json'),
+ path.join(__dirname, '../' + outputFolder + '/assets.json'),
@m4dz
m4dz Jan 10, 2017 Member

Like in base config, but I ask myself if we shouldn't export those values in a dedicated file, to centralize them. Any preference?

@kosssi
kosssi Jan 10, 2017 Contributor

done

@m4dz m4dz requested review from goldoraf and GoOz Jan 10, 2017
@GoOz

Seems pretty good to me. 👍
Not much to say, @goldoraf did most of the part you edited. So i'd wait for his input.

@m4dz
m4dz approved these changes Jan 10, 2017 View changes
@kosssi kosssi merged commit 499b850 into cozy:master Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kosssi kosssi deleted the kosssi:feature/mobile branch Jan 11, 2017
@m4dz m4dz pushed a commit that referenced this pull request Jan 11, 2017
Cozy publish: Merge pull request #16 from kosssi/feature/mobile
generated from commit 499b850
fc394c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment