fix: Shared Element when the document has no path #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lohse
reviewed
Aug 4, 2020
Crash--
force-pushed
the
fix/SharingForPHotos
branch
from
db6990c
to
4fa904c
Compare
We assumed that a document has a path or at least that we can fetch it. It works well with an io.cozy.files but not with an io.cozy.albums since an album doesn't have a path. Instead of displaying nothing if there is no path, let's just not make the call to the methods that need the path to work.
Crash--
force-pushed
the
fix/SharingForPHotos
branch
from
4fa904c
to
8fea1bb
Compare
y-lohse
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We assumed that a document has a path or at least that
we can fetch it. It works well with an io.cozy.files but
not with an io.cozy.albums since an album doesn't have a
path.
Instead of displaying nothing if there is no path, let's just
not make the call to the methods that need the path to work.