From 49c19c94dc67a3db2f8534a1e6ca253e1f08fff7 Mon Sep 17 00:00:00 2001 From: Przemyslaw Zegan Date: Tue, 12 Oct 2021 12:56:11 +0000 Subject: [PATCH] app/crypto-perf: fix AAD template copy overrun This patch fixes a possible buffer overrun problem in crypto perf test. Previously when user configured AAD size is over 12 bytes the copy of template AAD will cause a buffer overrun. The problem is fixed by only copy up to 12 bytes of AAD template. Fixes: 8a5b494a7f99 ("app/test-crypto-perf: add AEAD parameters") Cc: stable@dpdk.org Signed-off-by: Przemyslaw Zegan Acked-by: Fan Zhang --- app/test-crypto-perf/cperf_test_vectors.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/test-crypto-perf/cperf_test_vectors.c b/app/test-crypto-perf/cperf_test_vectors.c index 4bba405961..7da1a8fa2e 100644 --- a/app/test-crypto-perf/cperf_test_vectors.c +++ b/app/test-crypto-perf/cperf_test_vectors.c @@ -590,6 +590,10 @@ cperf_test_vector_get_dummy(struct cperf_options *options) rte_free(t_vec); return NULL; } + + if (options->aead_aad_sz > sizeof(aad)) + options->aead_aad_sz = sizeof(aad); + memcpy(t_vec->aad.data, aad, options->aead_aad_sz); t_vec->aad.phys_addr = rte_malloc_virt2iova(t_vec->aad.data); t_vec->aad.length = options->aead_aad_sz;