New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test code refactoring #27

Merged
merged 2 commits into from Jul 25, 2015

Conversation

Projects
None yet
2 participants
@monsieurp
Contributor

monsieurp commented Jul 8, 2015

Hi there

This is a pull request that basically tries to render the test code a bit less criptic by using IO::Handler OO interface in order to turn on autoflushing instead of the cryptic $|. For the time being, I have only made the change to a single test file but I have noticed $| is used almost everywhere. I can send another PR that would make that change across all test files. Also, there seems to be a missing semicolon in a function. I ran `perl -c' on that special file but even with or without the semicolon, the output stays the same:

patrice@lair ~/git_projects/CPAN-Reporter $ perl -c t/Helper.pm
t/Helper.pm syntax OK

Maybe I'm missing something here.

Thanks a lot and looking forward to your suggestions.

Cheers,
Patrice

@dagolden dagolden merged commit 193e8a2 into cpan-testers:master Jul 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jul 25, 2015

Thank you very much! Sorry it took so long to review.

ghost commented Jul 25, 2015

Thank you very much! Sorry it took so long to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment