Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Rcpp:::CxxFlags and Rcpp:::LdFlags() in Makevar #6

Closed
cpanse opened this issue Dec 24, 2018 · 1 comment
Closed

remove Rcpp:::CxxFlags and Rcpp:::LdFlags() in Makevar #6

cpanse opened this issue Dec 24, 2018 · 1 comment
Assignees

Comments

@cpanse
Copy link
Owner

cpanse commented Dec 24, 2018

Received: from edge20.ethz.ch (82.130.99.26) by CAS11.d.ethz.ch
 (172.31.38.211) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 23 Dec
 2018 10:00:13 +0100
Received: from phil1.ethz.ch (129.132.65.2) by edge20.ethz.ch (82.130.99.26)
 with Microsoft SMTP Server id 14.3.408.0; Sun, 23 Dec 2018 10:00:07 +0100
Received: from relay11.mail.ox.ac.uk ([129.67.1.162])	by phil1.ethz.ch with
 esmtps (TLSv1:AES256-SHA:256)	(Exim 4.69)	(envelope-from
 <ripley@stats.ox.ac.uk>)	id 1gazcC-0005Lm-5L	for cp@fgcz.ethz.ch; Sun, 23 Dec
 2018 10:00:06 +0100
Received: from smtp02.stats.ox.ac.uk ([163.1.211.205])	by
 relay11.mail.ox.ac.uk with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.89)	(envelope-from <ripley@stats.ox.ac.uk>)	id 1gazcC-0005h6-Ze; Sun,
 23 Dec 2018 09:00:04 +0000
Received: from cpc69403-oxfd27-2-0-cust549.4-3.cable.virginm.net
 ([82.15.58.38] helo=tystie3.local)	by smtp02.stats.ox.ac.uk with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)	(Exim 4.84_2)	(envelope-from
 <ripley@stats.ox.ac.uk>)	id 1gazc7-0003LJ-0F; Sun, 23 Dec 2018 08:59:59 +0000
To: Jose Francisco Loff <jfloff@phistat.com>, Philip Rinn
	<philip.rinn@uni-oldenburg.de>, Ye Henry Li <hlowl2@gmail.com>, Shichao Gao
	<xgdgsc@gmail.com>, Daniel Sabanes Bove <daniel.sabanesbove@gmx.net>, "James
 Hiebert" <hiebert@uvic.ca>, Vincent Miele <vincent.miele@univ-lyon1.fr>, Matt
 Pennell <mwpennell@gmail.com>, Christian Panse <cp@fgcz.ethz.ch>
CC: CRAN <CRAN@r-project.org>
Reply-To: CRAN <CRAN@r-project.org>
From: Prof Brian Ripley <ripley@stats.ox.ac.uk>
Subject: CRAN packages using Rcpp:::CxxFlags
Message-ID: <bee18bc9-7c72-e14d-9226-0b0731c074e5@stats.ox.ac.uk>
Date: Sun, 23 Dec 2018 08:59:58 +0000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.3.3
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-Oxmail-Spam-Status: score=0.0 tests=none
X-Oxmail-Spam-Level: /
X-Filter-Node: phil1.ethz.ch
X-Spam-Level: --
X-Spam-Status: hits=-2.3 tests=RCVD_IN_DNSWL_MED,SPF_PASS
X-Spam-Flag: NO
Return-Path: ripley@stats.ox.ac.uk
X-MS-Exchange-Organization-AuthSource: edge20.ethz.ch
X-MS-Exchange-Organization-AuthAs: Anonymous
X-MS-Exchange-Organization-AVStamp-Mailbox: SMEXZmb@;1470500;0;This mail has
 been scanned by Trend Micro ScanMail for Microsoft Exchange;
X-MS-Exchange-Organization-SCL: 0
MIME-Version: 1.0

For years the recommended way to link to Rcpp has been

LinkingTo: Rcpp

in the DESCRIPTION file, and using Rcpp:::CxxFlags has been unnecessary. 
Yet packages

     ALKr Langevin PAC Rsomoclu bfp climdex.pcic dynsbm geiger protViz

still do so.  Please remove it, and any use of Rcpp:::LdFlags().

Please do so before Jan 16 to safely retain the package on CRAN.

-- 
Brian D. Ripley,                  ripley@stats.ox.ac.uk
Emeritus Professor of Applied Statistics, University of Oxford
@cpanse cpanse self-assigned this Dec 24, 2018
@cpanse cpanse closed this as completed in e7a4d7d Dec 24, 2018
@cpanse
Copy link
Owner Author

cpanse commented Dec 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant