Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recmapGRASP testcase solution vector differs due to change of default method for generating from a discrete uniform distribution #14

Closed
cpanse opened this issue Mar 6, 2019 · 1 comment
Assignees

Comments

@cpanse
Copy link
Owner

@cpanse cpanse commented Mar 6, 2019


Received: from hornik by aragorn.wu.ac.at with local (Exim 4.92) (envelope-from <Kurt.Hornik@R-project.org>) id 1h1RAu-000056-0f; Wed, 06 Mar 2019 08:41:12 +0100
From: Kurt Hornik <Kurt.Hornik@r-project.org>
To: christian.panse@gmail.com
Subject: CRAN package recmap
Cc: CRAN@r-project.org
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Reply-To: CRAN@r-project.org
Message-Id: <E1h1RAu-000056-0f@aragorn.wu.ac.at>
Date: Wed, 06 Mar 2019 08:41:12 +0100
Content-Transfer-Encoding: quoted-printable

Dear maintainer,

Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_recmap.html>.

The check problems with current R-devel are from

     =E2=80=A2 The default method for generating from a discrete uniform
       distribution (used in sample(), for instance) has been changed.
       ...
       The previous method can be requested using RNGkind() or
       RNGversion() if necessary for reproduction of old results.

To make your package successfully pass the checks for current R-devel
and R-release you may find it most convenient to insert

  suppressWarnings(RNGversion("3.5.0"))

before calling set.seed() in your example, vignette and test code (where
the difference in RNG sample kinds matters, of course).

Note that this ensures using the (old) non-uniform "Rounding" sampler
for all 3.x versions of R, and does not add an R version dependency.
Note also that the new "Rejection" sampler which R will use from 3.6.0
onwards by default is definitely preferable over the old one, so that
the above should really only be used as a temporary measure for
reproduction of the previous behavior (and the run time tests relying on
it).

Please correct before 2019-03-20 to safely retain your package on CRAN.

Best,
-k

screenshot 2019-03-06 at 14 46 46

@cpanse cpanse self-assigned this Mar 6, 2019
@cpanse
Copy link
Owner Author

@cpanse cpanse commented Mar 9, 2019

IMG_0186

@cpanse cpanse closed this in 3971809 Mar 9, 2019
cpanse added a commit that referenced this issue Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.