missing_build_prereqs probably shouldn't consider files in "xt/{author,release}/*" #11

Open
kentfredric opened this Issue Jan 8, 2013 · 6 comments

Comments

Projects
None yet
4 participants
@kentfredric

http://cpants.cpanauthors.org/dist/Net-Minecraft-Login/errors

Its nice it reports these, but these tests are never run during installation, so they're not a "build" prerequisite at all.

at best, these should be deemed "Develop" prerequisites , which my dist already declares most of: https://metacpan.org/source/KENTNL/Net-Minecraft-Login-0.001000/META.json#L31

@dolmen

This comment has been minimized.

Show comment
Hide comment
@dolmen

dolmen Jan 18, 2013

Member

👍, but this should be reported against Module::CPANTS::Analyse.

Member

dolmen commented Jan 18, 2013

👍, but this should be reported against Module::CPANTS::Analyse.

@kentfredric

This comment has been minimized.

Show comment
Hide comment
@kentfredric

kentfredric Jan 18, 2013

Hm, I can't find the string "missing_build_prereqs" anywhere in MCA, so this bug isn't 1:1

Hm, I can't find the string "missing_build_prereqs" anywhere in MCA, so this bug isn't 1:1

@kentfredric

This comment has been minimized.

Show comment
Hide comment
@kentfredric

kentfredric Jan 18, 2013

Incidentally, if this really is MCA's fault, then why does it never pose a problem to Test::Kwalitee, which all my dists use?

Incidentally, if this really is MCA's fault, then why does it never pose a problem to Test::Kwalitee, which all my dists use?

@charsbar

This comment has been minimized.

Show comment
Hide comment
@charsbar

charsbar Apr 13, 2013

Contributor

Asked Rik (also the author of Module::Instal:AuthorTests) at QAH and was told all files in xt/ should be ignored, thus cpants/Module-CPANTS-Analyse@83e91b5

Will rerun the analyzer when everything is sorted.

Contributor

charsbar commented Apr 13, 2013

Asked Rik (also the author of Module::Instal:AuthorTests) at QAH and was told all files in xt/ should be ignored, thus cpants/Module-CPANTS-Analyse@83e91b5

Will rerun the analyzer when everything is sorted.

@karenetheridge

This comment has been minimized.

Show comment
Hide comment
@karenetheridge

karenetheridge Oct 8, 2013

This should probably be filed in https://rt.cpan.org/Dist/Display.html?Queue=Module-CPANTS-Analyse, rather than in the queue for the website itself.

(however, it would be sensible for prereqs in xt/{author,release,smoke} to be listed as develop requires.)

This should probably be filed in https://rt.cpan.org/Dist/Display.html?Queue=Module-CPANTS-Analyse, rather than in the queue for the website itself.

(however, it would be sensible for prereqs in xt/{author,release,smoke} to be listed as develop requires.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment