Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

CPANTS not recognising license information when cpants_lint seems to #44

Closed
neilbowers opened this Issue · 2 comments

2 participants

@neilbowers

Hi,

If you look at my CPANTS page:

http://cpants.cpanauthors.org/author/neilb

You'll see there's only one dist with a warning that isn't is_prereq: Business-CCCheck, which fails "has known license in source file".

But if I run cpants_lint.pl on the dist it says:

Checked dist        Business-CCCheck-0.09.tar.gz
Kwalitee rating     146.67% (22/15)

Congratulations for building a 'perfect' distribution!

And if I read the pod into a string and call:

my @guesses = Software::LicenseUtils->guess_license_from_pod($source);

Then I get:

Software::License::GPL_1
Software::License::GPL_2
Software::License::GPL_3

The metadata for the dist says LICENSE => 'gpl_2', and text of the lead module has the right text for GPL 2.

There is another module in the dist that has a funny licensing situation, but my understanding of the doc is that it's down to the lead module?

Cheers,
Neil

@charsbar charsbar referenced this issue from a commit
@charsbar charsbar added a test case for #44 259244a
@charsbar charsbar closed this issue from a commit in cpants/Module-CPANTS-Analyse
@charsbar charsbar has_known_license_in_source_file should pass if any of the modules in…
… a distribution has known license.

- not all of them need to have known license (at least now)
- should fix cpants/www-cpants#44
af27551
@charsbar
Owner

Fixed the module and added a test. Wait a few days (or a bit more as it's taking more time then expected to regenerate CPANTS databases) until this fix actually takes effect on the site.

@neilbowers

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.