New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smashrun: Fetch activities without pagination when doing exhaustive sync #455

Merged
merged 2 commits into from Oct 13, 2018

Conversation

Projects
None yet
3 participants
@campbellr
Contributor

campbellr commented Aug 8, 2018

@chrislukic suggested that we disable pagination when performing an
exhaustive sync to help reduce the load on his servers.

While we're at it, we can also take advantage of the new(-ish) limit
kwarg in SmashrunClient.get_activities to fix an off-by-one error
where we always fetched 30 activities during the non-exhaustive
sync when we only intended to fetch 20.

Fixes #448

campbellr added some commits Aug 1, 2018

Bump smashrun-client dependency to 0.6.0
0.6.0 introduces the ability to perform a bulk fetch of all activities
without performing any pagination.
Smashrun: fetch activities without pagination when doing exhaustive sync
Chris Lukic suggested that we disable pagination when performing an
exhaustive sync to help reduce the load on his servers.

While we're at it, we can also take advantage of the new(-ish) limit
kwarg to fix an off-by-one error where we always fetched 30 activities
when we only intended to fetch 20.

Fixes #448
@xuopled

xuopled approved these changes Aug 8, 2018

@campbellr

This comment has been minimized.

Show comment
Hide comment
@campbellr

campbellr Sep 23, 2018

Contributor

@cpfair any chance you could merge this? It sounds like it will significantly reduce the load on the Smashrun servers.

Contributor

campbellr commented Sep 23, 2018

@cpfair any chance you could merge this? It sounds like it will significantly reduce the load on the Smashrun servers.

@cpfair cpfair merged commit b09e57c into cpfair:master Oct 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cpfair

This comment has been minimized.

Show comment
Hide comment
@cpfair

cpfair Oct 13, 2018

Owner

Sorry, I completely missed this PR when it first came in!

Owner

cpfair commented Oct 13, 2018

Sorry, I completely missed this PR when it first came in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment