Skip to content

P2351: add [[nodiscard]] to cast-like library wrappers [WIP] #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

P2351: add [[nodiscard]] to cast-like library wrappers [WIP] #4579

wants to merge 1 commit into from

Conversation

@hanickadot
Copy link
Contributor

@hanickadot hanickadot commented Apr 5, 2021

bit_cast, to_integer, forward, move, move_if_noexcept, as_const, to_underlying, and identity::operator()

add [[nodiscard]] to: bit_cast, to_integer, forward, move, move_if_no…
ffda516 
…except, as_const, to_underlying, and identity::operator()
@hanickadot hanickadot changed the title P2351: add [[nodiscard]] to: cast-like library wrappers [WIP] P2351: add [[nodiscard]] to cast-like library wrappers [WIP] Apr 5, 2021
@jensmaurer
Copy link
Member

jensmaurer commented Apr 6, 2021

Which part is "WIP" here?

@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Apr 6, 2021
@hanickadot
Copy link
Contributor Author

hanickadot commented Apr 6, 2021

Paper is WIP. LEWG is discussing if the paper is worth of spending time on it. My idea is to have an open pull request as part of the paper. If that's not what you want here close it.

@jensmaurer
Copy link
Member

jensmaurer commented Apr 6, 2021

@tkoeppe, please state whether you consider the change here editorial.
(My view: There is no general or specific guidance from LWG / LEWG for this matter, so this doesn't feel editorial.)

@hanickadot
Copy link
Contributor Author

hanickadot commented Apr 6, 2021

No, I don't think this is editorial (as much I would like to). I want guidance from LEWG/LWG too. But I also like the idea that the paper is accompanied with an open pull request to the draft. To make it easier for editors.

@jensmaurer jensmaurer added lwg Issue must be reviewed by LWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking. and removed decision-required A decision of the editorial group (or the Project Editor) is required. labels Apr 6, 2021
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 24, 2021
@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Jul 30, 2024

It seems that this PR should be abandoned due to P2422R1.

@jwakely
Copy link
Member

jwakely commented Jul 30, 2024

More specifically, because of https://isocpp.org/std/standing-documents/sd-9-library-evolution-policies, which set the policy.

@hanickadot hanickadot closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lwg Issue must be reviewed by LWG. needs rebase The pull request needs a git rebase to resolve merge conflicts. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hanickadot @jensmaurer @frederick-vs-ja @jwakely @wg21bot