[format.string.escaped] Fix invalid examples #5751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brevzin can you have a look at these changes? |
mordante
force-pushed
the
P2286-example-fixes
branch
from
3d024f5 to
086e402
Compare
mordante
commented
Aug 19, 2022
mordante
force-pushed
the
P2286-example-fixes
branch
from
086e402 to
b72734e
Compare
While implementing new features introduced by P2286R8 Formatting Ranges I noticed some issues in the examples. These issues are in the paper too. For s3 the alternative would be to adjust the output instead of the input.
mordante
force-pushed
the
P2286-example-fixes
branch
from
b72734e to
dcd64eb
Compare
Looks good to me, thanks for the fixes. What happened to |
See #5700 (comment) and #5702. |
I find this hilarious and more than a little ironic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing new features introduced by P2286R8 Formatting Ranges
I noticed some issues in the examples. These issues are in the paper
too.
For s3 the alternative would be to adjust the output instead of the
input.