Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1279 std::breakpoint #307

Closed
wg21bot opened this issue Jan 30, 2019 · 8 comments
Closed

P1279 std::breakpoint #307

wg21bot opened this issue Jan 30, 2019 · 8 comments

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Jan 30, 2019

P1279R0 std::breakpoint (Isabella Muerte)

@wg21bot wg21bot added this to the 2019-02 milestone Jan 30, 2019
@wg21bot wg21bot added LEWG Library Evolution SG14 Low Latency labels Jan 30, 2019
@jensmaurer
Copy link
Member

Marked as "backlog" on San Diego EWG-I wiki.

@jensmaurer jensmaurer added EWGI Evolution Incubator and removed LEWG Library Evolution labels Jan 30, 2019
@jfbastien jfbastien added this to EWGIMonday in EWGIKonaFeb2019 Feb 16, 2019
@jfbastien jfbastien moved this from EWGIMonday to Schedule me in EWGIKonaFeb2019 Feb 16, 2019
@jfbastien jfbastien moved this from Schedule me to EWGIMonday in EWGIKonaFeb2019 Feb 16, 2019
@jfbastien jfbastien moved this from EWGIMonday to EWGITuesday in EWGIKonaFeb2019 Feb 16, 2019
@jfbastien jfbastien moved this from EWGITuesday to EWGIMonday in EWGIKonaFeb2019 Feb 19, 2019
@jfbastien
Copy link
Collaborator

jfbastien commented Feb 19, 2019

EWG-I in Kona:
Do we want SG20 Education to see this?
SF F N A SA
4 0 4 2 1
Do we want SG15 Tooling to see this?
SF F N A SA
4 7 1 0 0
Do we want to see something like this again in EWGI?
SF F N A SA
4 4 3 1 0
(A vote: have to think more about technical issues, want to see in SG15 first, introduces semantics outside the language)

@jfbastien jfbastien added SG15 Tooling SG20 Education and removed EWG-I Kona labels Feb 19, 2019
@jfbastien jfbastien modified the milestones: 2019-02, 2019-07 Feb 24, 2019
@jensmaurer
Copy link
Member

jensmaurer commented Mar 21, 2019

SG20 in Kona:
"We encourage Isabella to explore this proposal further"
SF | F | N | A | SA
7 | 5 | 3 | 1 | 0

@jfbastien jfbastien removed EWGI Evolution Incubator SG20 Education labels Jul 8, 2019
@jensmaurer jensmaurer modified the milestones: 2019-07, 2019-11 Aug 26, 2019
@brycelelbach
Copy link

brycelelbach commented Oct 3, 2019

Denver 2019-09 Tooling Minutes for P1279

P1279R0 std::breakpoint

Champion: Isabella Muerte

Minute Taker: Mark Zeren

Start Overview: 14:15

Start Polling: 14:40

POLL: Forward P1279, modified to specify the std::breakpoint function as implementation-defined with a (non-normative) note describing how debuggers should use it, for C++23.

Strongly For Weakly For Neutral Weakly Against Strongly Against
9 6 0 0 0

Attendance: 16

CONSENSUS: Unanimously in favor.

Michael Spencer appointed to help redraft.

Forward to EWG(I) + LEWGI + SG1

Questions for other groups:

  • Needs to be bikeshedded.
  • Which header?
  • Should it be freestanding?

End: 14:47

CONSENSUS: The Tooling Study Group sends P1279R0 (std::breakpoint), with the guidance below, to EWGI/LEWGI/SG1 for C++23.

  • Specify the std::breakpoint function as implementation-defined with a (non-normative) note describing how debuggers should use it.

@brycelelbach brycelelbach added C++23 Targeted at C++23 EWGI Evolution Incubator LEWGI Library Evolution Incubator SG1 Concurrency and removed SG14 Low Latency SG15 Tooling labels Oct 3, 2019
@ogiroux ogiroux added this to Wednesday in SG1Belfast2019 Nov 3, 2019
@brycelelbach
Copy link

brycelelbach commented Nov 6, 2019

Belfast 2019-11 LEWGI Minutes

P1279R0 std::breakpoint: Design Guidance

Chair: Bryce Adelstein Lelbach

Champion: Bryce Adelstein Lelbach

Minute Taker: Mark Hoemmen

Start Review: 11-05 11:32

Start Polling: 11:35

POLL: Throwing exceptions when at a std::breakpoint in the debugger and catching them in the program is a use case we should support.

Strongly For Weakly For Neutral Weakly Against Strongly Against
0 2 1 5 6

Attendance: 16

There is consensus against that.

POLL: Remove noexcept from std::breakpoint.

Strongly For Weakly For Neutral Weakly Against Strongly Against
1 2 1 6 5

Attendance: 16

F: I think making it noexcept limits implementation freedom.

There is consensus against that.

POLL: Exploring making std::breakpoint a macro.

Strongly For Weakly For Neutral Weakly Against Strongly Against
3 2 5 4 1

Attendance: 16

This has no consensus.

POLL: Name of std::breakpoint (vote for all you can tolerate, vote as many times as you like).

Options Votes
breakpoint 13
break_point 7
brake 4
do_not_commit 1
debug_break 10
pause 3
debug_breakpoint 11
trap 1
debug_callback 1
debug_trap 1

Attendance: 17

POLL: Name of std::breakpoint (vote once for your favorite).

Options Votes
breakpoint 6
break_point 0
debug_break 2
debug_breakpoint 6

Attendance: 17

POLL: Name of std::breakpoint.

Strongly breakpoint Weakly breakpoint Neutral Weakly debug_breakpoint Strongly debug_breakpoint
5 3 1 3 6

Attendance: 18

The consensus is to call this either breakpoint or debug_breakpoint; author's choice.

End: 12:08

CONSENSUS: LEWGI sends P1279R0 (std::breakpoint), with the guidance below, to LEWG and EWGI.

  • Add a section discussing existing practice/non-portable implementations (MSVC, GCC, etc).

@brycelelbach brycelelbach added LEWG Library Evolution and removed LEWGI Library Evolution Incubator labels Nov 6, 2019
@ogiroux ogiroux moved this from Wednesday to Friday in SG1Belfast2019 Nov 6, 2019
@ogiroux ogiroux moved this from Friday to Thursday in SG1Belfast2019 Nov 7, 2019
@ogiroux ogiroux removed the SG1 Concurrency label Nov 8, 2019
@ogiroux
Copy link
Collaborator

ogiroux commented Nov 8, 2019

SG1 sees no SG1 concerns with std::breakpoint:
SF F N A SA
11 6 0 0 0
Unanimous consent

@tituswinters
Copy link

EWGI/EWG are going to handle this first.

@tituswinters tituswinters removed the LEWG Library Evolution label Jan 29, 2020
@theres-waldo theres-waldo added this to Unscheduled in EWG-I Prague Feb 7, 2020
@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-06 Feb 18, 2020
@jensmaurer jensmaurer removed the C++23 Targeted at C++23 label Mar 7, 2020
@jensmaurer jensmaurer modified the milestones: 2020-telecon, 2021-telecon Dec 28, 2020
@cor3ntin
Copy link

The author informed me that she is no longer pursuing this paper.
If you are interested in pursuing this work further, reach out to her to get the paper's sources.

Closing for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EWGI Evolution Incubator
Projects
No open projects
Development

No branches or pull requests

7 participants