Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1679 String Contains function #457

Closed
wg21bot opened this issue Jun 23, 2019 · 8 comments · Fixed by cplusplus/draft#4373
Closed

P1679 String Contains function #457

wg21bot opened this issue Jun 23, 2019 · 8 comments · Fixed by cplusplus/draft#4373

Comments

@wg21bot
Copy link
Collaborator

@wg21bot wg21bot commented Jun 23, 2019

P1679R0 String Contains function (Wim Leflere)

@wg21bot wg21bot added this to the 2019-07 milestone Jun 23, 2019
@wg21bot wg21bot added the LEWGI label Jun 23, 2019
@brycelelbach
Copy link
Collaborator

@brycelelbach brycelelbach commented Jul 17, 2019

Cologne 2019-07 LEWGI Minutes

P1679R0 std::string::contains: Direction Review

Champion: Wim Leflere

Minute Taker: Phil Ratzloff

Start Overview: 07-17 15:53

Start Review: 15:59

This is the same paper as P1657R0, which is scheduled for Friday in LEWG.

Start Polling: 16:06

POLL: We should promise more committee time to pursuing the merger of P1679R0 and P1657R0 and forward it to LEWG for C++23, knowing that our time is scarce and this will leave less time for other work.

NO OBJECTION TO UNANIMOUS CONSENT.

Attendance: 18

End: 16:18

CONSENSUS: LEWGI sends the merger of P1679R0 and P1657R0, with the guidance below, to LEWG, for C++23.

@tituswinters
Copy link
Collaborator

@tituswinters tituswinters commented Jul 19, 2019

Discussing http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2019/p1679r0.html in

Forward to LWG for C++23 (but get the wording done).
SF F N A SA
1 10 5 1 1

Motion passes.

@tituswinters tituswinters added LWG and removed LEWG labels Jul 19, 2019
@jensmaurer jensmaurer removed this from the 2019-07 milestone Aug 23, 2019
@jensmaurer jensmaurer added this to the 2019-11 milestone Aug 23, 2019
@wg21bot
Copy link
Collaborator Author

@wg21bot wg21bot commented Oct 15, 2019

P1679R1 String Contains function (Wim Leflere, Paul Fee)

@jensmaurer jensmaurer removed this from the 2019-11 milestone Feb 18, 2020
@jensmaurer jensmaurer added this to the 2020-06 milestone Feb 18, 2020
@jensmaurer jensmaurer added IS and removed C++23 labels Feb 18, 2020
@JeffGarland
Copy link
Member

@JeffGarland JeffGarland commented May 12, 2020

Small group review notes for 3 minor updates on wiki. After revision should be ready for full group review.

@wg21bot
Copy link
Collaborator Author

@wg21bot wg21bot commented May 21, 2020

P1679R2 String Contains function (Wim Leflere, Paul Fee)

@JeffGarland
Copy link
Member

@JeffGarland JeffGarland commented Jul 24, 2020

Reviewed by full LWG June 12th 2020. Final result:

Poll: Put this up for C++23?
No objection to unanimous consent.

ACTION: Wakely will review the updated changes so that LWG does not need to look at this again.

Review notes
https://wiki.edg.com/bin/view/Wg21summer2020/P1679R2StringContainsFunction

@wg21bot
Copy link
Collaborator Author

@wg21bot wg21bot commented Aug 1, 2020

P1679R3 String Contains function (Wim Leflere, Paul Fee)

@wg21bot
Copy link
Collaborator Author

@wg21bot wg21bot commented Oct 26, 2021

Adopted 2020-11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

7 participants