Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1930 Towards a standard unit systems library #672

Closed
wg21bot opened this issue Oct 15, 2019 · 2 comments
Closed

P1930 Towards a standard unit systems library #672

wg21bot opened this issue Oct 15, 2019 · 2 comments
Labels
LEWGI Library Evolution Incubator SG6 Numerics
Milestone

Comments

@wg21bot
Copy link
Collaborator

wg21bot commented Oct 15, 2019

P1930R0 Towards a standard unit systems library (Vincent Reverdy)

@wg21bot wg21bot added LEWGI Library Evolution Incubator SG6 Numerics labels Oct 15, 2019
@wg21bot wg21bot added this to the 2019-11 milestone Oct 15, 2019
@brycelelbach
Copy link
Collaborator

brycelelbach commented Nov 9, 2019

Belfast 2019-11 LEWGI Minutes

P1935R0 Units Library Rationale: Direction Review

Chair: Bryce Adelstein Lelbach

Champion: Mateusz Pusz

Minute Taker: Marco Foco

Start Review: 11-07 8:41

std::chrono is a good litmus test for this feature, as it's an existing part of the library that has a notion of units.

Design goals starting on slide 10.

Priorities: safety > performance > ease of use

POLL: Quantity kind (width, height, etc) should be a priority for the initial release of this feature.

Strongly For Weakly For Neutral Weakly Against Strongly Against
2 0 7 7 3

Attendance: 19

# of Authors: 1

Author Position: A

That has consensus against.

POLL: We should promise more committee time to pursuing adding common units (such as SI, customary, etc) to the standard library, knowing that our time is scarce and this will leave less time for other work.

Strongly For Weakly For Neutral Weakly Against Strongly Against
11 7 4 2 0

Attendance: 23

# of Authors: 1

Author Position: SF

A: I think only SI will have too small of an audience; I want something extensible.

That has consensus.

POLL: We should promise more committee time to pursuing a standard library framework for user defined units and unit systems, knowing that our time is scarce and this will leave less time for other work.

Strongly For Weakly For Neutral Weakly Against Strongly Against
10 8 4 1 1

Attendance: 24

# of Authors: 1

Author Position: SF

A: Afraid the audience that needs this is too small.

SA: Currency is over my dead body.

That has consensus.

POLL: In a C++ standard units framework, C++ conversions should not vary over runtime.

Strongly For Weakly For Neutral Weakly Against Strongly Against
8 8 2 3 0

Attendance: 23

# of Authors: 1

Author Position: SF

POLL: We should plan for versioning of standard library physical constants.

Strongly For Weakly For Neutral Weakly Against Strongly Against
6 11 3 0 0

Attendance: 23

# of Authors: 0

That has unanimous consent.

POLL: Compile time diagnostics are a Quality-of-Implementation (QOI) matter and should not influence the standard units library API.

Strongly For Weakly For Neutral Weakly Against Strongly Against
8 3 2 6 3

Attendance: 23

# of Authors: 1

Authors Position: SA

That has no consensus.

Lunch: 12:00

Resume: 13:35

Minute Taker: Ben Craig

POLL: A standard library of quantity concepts are a priority for the initial release of a standard library units framework.

Strongly For Weakly For Neutral Weakly Against Strongly Against
1 5 10 5 0

Attendance: 21

# of Authors: 1

Author Position: SF

A: I voted against because I don't think they should be a priority.

A: I voted against because of compile-time concerns.

That has no consensus.

POLL: We should promise more committee time to pursuing P1935R0 (A C++ Approach to Physical Units), knowing that our time is scarce and this will leave less time for other work.

Strongly For Weakly For Neutral Weakly Against Strongly Against
4 7 6 4 1

Attendance: 23

# of Authors: 1

Author Position: SF

SA: Existing practice seems unsettled, unclear but very large scope, worried it obscures precision from my developers, concerns about how it interacts with vectors and matrices.

End: 15:30

CONSENSUS: Bring a revision of P1935R0 (A C++ Approach to Physical Units), with the guidance below, to LEWGI and SG6 for further direction review.

  • Remove the proposed standard library quantity concepts.
  • Write a separate paper exploring using rational as a CNTTP.
  • Explore approaches for versioning standard library physical constants:
    • Version namespaces.
    • Add the version to the identifiers.
    • Template variables parameterized by a tag.
    • WEB's approach (see minutes).

@brycelelbach brycelelbach added the info Informational paper label Nov 9, 2019
@brycelelbach
Copy link
Collaborator

brycelelbach commented Nov 9, 2019

This is informative only, no action.

@jensmaurer jensmaurer modified the milestones: 2019-11, 2020-02 Dec 11, 2019
@brycelelbach brycelelbach added needs-revision Paper needs changes before it can proceed and removed info Informational paper needs-revision Paper needs changes before it can proceed labels Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LEWGI Library Evolution Incubator SG6 Numerics
Projects
None yet
Development

No branches or pull requests

3 participants