Skip to content

Conversation

@LB--
Copy link
Member

@LB-- LB-- commented May 4, 2013

The goal is to reduce header coupling so that each file has to include the header it needs and it can't get them by being included from other files.

For instance, a scenario to avoid:

//Class.cpp
#include <cstdint>
#include "OtherClass.hpp"
//...
//OtherClass.hpp
//...
std::uint8_t blah; //works due to include order (bad)
//...

EDIT: Also, it's pretty ugly and annoying to use "get" and "set" in the names of getter and setters - it should be obvious that they either get or set data, you don't want to type that every time.

@LB--
Copy link
Member Author

LB-- commented May 7, 2013

I've reverted the g/s change. Any opposition to the header include order?

@Thumperrr
Copy link
Member

No opposition. That seems like a fair style guide.

-Stephen Hall

On May 6, 2013, at 11:22 PM, "LB--" notifications@github.com wrote:

I've reverted the g/s change. Any opposition to the header include order?


Reply to this email directly or view it on GitHub.

Thumperrr pushed a commit that referenced this pull request May 13, 2013
Add include ordering rule to styleguide
@Thumperrr Thumperrr merged commit 607f37c into cpluspluscom:master May 13, 2013
@LB-- LB-- deleted the adjust-styleguide branch May 13, 2013 23:48
@ghost ghost assigned Thumperrr May 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants