From e89b4fbaec26af6257eca214ef41fb46c2fb41d5 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 28 Aug 2025 15:26:44 -0700 Subject: [PATCH 1/3] fix: pass inputs as strings --- action.yml | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/action.yml b/action.yml index 6aee249..e5cf693 100644 --- a/action.yml +++ b/action.yml @@ -369,7 +369,7 @@ runs: ) print $"\n(ansi purple)Installing workflow dependencies(ansi reset)" - mut uv_args = [sync --project $action_path --group action] + mut uv_args = [sync --project $action_path --group action --no-dev] if $verbosity { $uv_args = $uv_args | append '-v' } @@ -392,27 +392,27 @@ runs: $env.UV_CACHE_DIR = $env.RUNNER_TEMP | path join 'cpp-linter-action-cache' let args = [ - --style="${{ inputs.style }}" - --extensions=${{ inputs.extensions }} - --tidy-checks="${{ inputs.tidy-checks }}" - --repo-root=${{ inputs.repo-root }} - --version=${{ inputs.version }} - --verbosity=${{ inputs.verbosity }} - --lines-changed-only=${{ inputs.lines-changed-only }} - --files-changed-only=${{ inputs.files-changed-only }} - --thread-comments=${{ inputs.thread-comments }} - --no-lgtm=${{ inputs.no-lgtm }} - --step-summary=${{ inputs.step-summary }} - --ignore="${{ inputs.ignore }}" - --ignore-tidy="${{ inputs.ignore-tidy }}" - --ignore-format="${{ inputs.ignore-format }}" - --database=${{ inputs.database }} - --file-annotations=${{ inputs.file-annotations }} - --extra-arg="${{ inputs.extra-args }}" - --tidy-review="${{ inputs.tidy-review }}" - --format-review="${{ inputs.format-review }}" - --passive-reviews="${{ inputs.passive-reviews }}" - --jobs=${{ inputs.jobs }} + '--style=${{ inputs.style }}' + --extensions '${{ inputs.extensions }}' + '--tidy-checks=${{ inputs.tidy-checks }}' + --repo-root ${{ inputs.repo-root }} + --version ${{ inputs.version }} + --verbosity ${{ inputs.verbosity }} + --lines-changed-only ${{ inputs.lines-changed-only }} + --files-changed-only ${{ inputs.files-changed-only }} + --thread-comments ${{ inputs.thread-comments }} + --no-lgtm ${{ inputs.no-lgtm }} + --step-summary ${{ inputs.step-summary }} + '--ignore=${{ inputs.ignore }}' + '--ignore-tidy=${{ inputs.ignore-tidy }}' + '--ignore-format=${{ inputs.ignore-format }}' + --database ${{ inputs.database }} + --file-annotations ${{ inputs.file-annotations }} + '--extra-arg=${{ inputs.extra-args }}' + --tidy-review ${{ inputs.tidy-review }} + --format-review ${{ inputs.format-review }} + --passive-reviews ${{ inputs.passive-reviews }} + --jobs ${{ inputs.jobs }} ] mut uv_args = [run --no-sync --project $action_path --directory (pwd)] From b4cddeb87d503f5992ff2a25f737ec5dc5ba727f Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 28 Aug 2025 20:20:00 -0700 Subject: [PATCH 2/3] conform pattern per AI review --- action.yml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/action.yml b/action.yml index e5cf693..ae87dc6 100644 --- a/action.yml +++ b/action.yml @@ -393,26 +393,26 @@ runs: let args = [ '--style=${{ inputs.style }}' - --extensions '${{ inputs.extensions }}' + '--extensions=${{ inputs.extensions }}' '--tidy-checks=${{ inputs.tidy-checks }}' - --repo-root ${{ inputs.repo-root }} - --version ${{ inputs.version }} - --verbosity ${{ inputs.verbosity }} - --lines-changed-only ${{ inputs.lines-changed-only }} - --files-changed-only ${{ inputs.files-changed-only }} - --thread-comments ${{ inputs.thread-comments }} - --no-lgtm ${{ inputs.no-lgtm }} - --step-summary ${{ inputs.step-summary }} + '--repo-root=${{ inputs.repo-root }}' + '--version=${{ inputs.version }}' + '--verbosity=${{ inputs.verbosity }}' + '--lines-changed-only=${{ inputs.lines-changed-only }}' + '--files-changed-only=${{ inputs.files-changed-only }}' + '--thread-comments=${{ inputs.thread-comments }}' + '--no-lgtm=${{ inputs.no-lgtm }}' + '--step-summary=${{ inputs.step-summary }}' '--ignore=${{ inputs.ignore }}' '--ignore-tidy=${{ inputs.ignore-tidy }}' '--ignore-format=${{ inputs.ignore-format }}' - --database ${{ inputs.database }} - --file-annotations ${{ inputs.file-annotations }} + '--database=${{ inputs.database }}' + '--file-annotations=${{ inputs.file-annotations }}' '--extra-arg=${{ inputs.extra-args }}' - --tidy-review ${{ inputs.tidy-review }} - --format-review ${{ inputs.format-review }} - --passive-reviews ${{ inputs.passive-reviews }} - --jobs ${{ inputs.jobs }} + '--tidy-review=${{ inputs.tidy-review }}' + '--format-review=${{ inputs.format-review }}' + '--passive-reviews=${{ inputs.passive-reviews }}' + '--jobs=${{ inputs.jobs }}' ] mut uv_args = [run --no-sync --project $action_path --directory (pwd)] From 16f5b85de606fd1f10dd7896fe2d7edbc5ce3561 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Thu, 28 Aug 2025 21:36:18 -0700 Subject: [PATCH 3/3] reduce expected warnings in uv debug logs --- action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/action.yml b/action.yml index ae87dc6..667223d 100644 --- a/action.yml +++ b/action.yml @@ -369,7 +369,7 @@ runs: ) print $"\n(ansi purple)Installing workflow dependencies(ansi reset)" - mut uv_args = [sync --project $action_path --group action --no-dev] + mut uv_args = [sync --project $action_path --group action --no-dev --link-mode=copy] if $verbosity { $uv_args = $uv_args | append '-v' }