From 5d98ffaf09c9d1c67460136161fef126db7789b2 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Tue, 11 Nov 2025 17:18:32 -0800 Subject: [PATCH 1/2] chore(dev): fix benchmark CI about py-binding artifact Previously, the glob patterns used to handle the py-binding artifacts were not concise enough to identify the CPython wheel. This resulted in incorrectly trying to install the PyPy wheel that was uploaded with the CPython wheel as build artifacts. --- .github/workflows/benchmark.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 64c3c9fe..50112471 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -93,7 +93,7 @@ jobs: uses: actions/upload-artifact@v5 with: name: wheel - path: dist/* + path: dist/cpp_linter-*-cp3*-abi3-*.whl benchmark: name: Measure Performance Difference @@ -132,7 +132,7 @@ jobs: shell: nu {0} run: |- let new_py = ( - glob "../wheel/cpp_linter-*.whl" + glob "../wheel/cpp_linter-*-cp3*-abi3-*.whl" | first | path expand ) From bbcc584f554e8d40a820ceba387a4a0289a5d949 Mon Sep 17 00:00:00 2001 From: Brendan <2bndy5@gmail.com> Date: Tue, 11 Nov 2025 17:33:09 -0800 Subject: [PATCH 2/2] ensure artifact-upload fails if no files were uploaded --- .github/workflows/benchmark.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 50112471..7693cad6 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -94,6 +94,7 @@ jobs: with: name: wheel path: dist/cpp_linter-*-cp3*-abi3-*.whl + if-no-files-found: error benchmark: name: Measure Performance Difference