From b0fdd3db512a76ddae82fc19a2978646508a8487 Mon Sep 17 00:00:00 2001 From: Tomas Lenc Date: Fri, 4 Dec 2020 16:40:13 +0100 Subject: [PATCH 1/2] suppress warnings when verbose==0 Often, events are saved one-by-one during acquisition. This produces lots of warnings because all the events before the one current one are empty in the logFile. One would expect that these warnings can be suppressed by setting cfg.verbose to 0. Simply adding this condition to the saveEventsFile does the job. --- src/saveEventsFile.m | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/saveEventsFile.m b/src/saveEventsFile.m index bf4dc656..cdaa7df5 100644 --- a/src/saveEventsFile.m +++ b/src/saveEventsFile.m @@ -284,7 +284,7 @@ function printHeaderExtraColumns(logFile) logFile(iEvent).(namesExtraColumns{iExtraColumn}) = data; - if ~ischar(data) && any(isnan(data)) + if ~ischar(data) && any(isnan(data)) && cfg.verbose > 0 warning('saveEventsFile:missingData', ... 'Missing some %s data for this event.', namesExtraColumns{iExtraColumn}); @@ -292,7 +292,7 @@ function printHeaderExtraColumns(logFile) disp(logFile(iEvent)); end - elseif ~ischar(data) && all(isnan(data)) + elseif ~ischar(data) && all(isnan(data)) && cfg.verbose > 0 warning('Missing %s data for this event.', namesExtraColumns{iExtraColumn}); if cfg.verbose > 1 @@ -402,7 +402,7 @@ function printHeaderExtraColumns(logFile) end % now save the event to log file (if not skipping) - if skipEvent + if skipEvent && cfg.verbose > 0 warning(warningMessageID, warningMessage); From bddedd21d12eac474a0938f39413050d070219f0 Mon Sep 17 00:00:00 2001 From: Tomas Lenc Date: Fri, 4 Dec 2020 18:04:13 +0100 Subject: [PATCH 2/2] fixed tests --- tests/test_saveEventsFileSave.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/test_saveEventsFileSave.m b/tests/test_saveEventsFileSave.m index b2b504aa..dd091429 100644 --- a/tests/test_saveEventsFileSave.m +++ b/tests/test_saveEventsFileSave.m @@ -52,7 +52,7 @@ function test_saveEventsFileSaveSkipEmptyEvents() [cfg, logFile] = setUp(); - cfg.verbose = false; + cfg.verbose = 1; % create the events file and header logFile = saveEventsFile('open', cfg, logFile); @@ -144,7 +144,7 @@ function test_saveEventsFileSaveArraySize() [cfg, logFile] = setUp(); - cfg.verbose = false; + cfg.verbose = 1; % create the events file and header logFile = saveEventsFile('open', cfg, logFile);