From 5e8d1cc526e72b2996685aedc4a83503245a0e67 Mon Sep 17 00:00:00 2001 From: Remi Gau Date: Thu, 24 Dec 2020 09:07:11 +0100 Subject: [PATCH 1/2] update miss hit config --- .github/workflows/miss_hit.yml | 14 +++++++++----- docs/requirements.txt => requirements.txt | 2 +- 2 files changed, 10 insertions(+), 6 deletions(-) rename docs/requirements.txt => requirements.txt (82%) diff --git a/.github/workflows/miss_hit.yml b/.github/workflows/miss_hit.yml index d4cb7ae8..caae9915 100644 --- a/.github/workflows/miss_hit.yml +++ b/.github/workflows/miss_hit.yml @@ -28,12 +28,16 @@ jobs: - name: Install dependencies run: | python -m pip install --upgrade pip setuptools - pip3 install install miss_hit + pip3 install -r requirements.txt - - name: Miss_hit code quality + - name: MISS_HIT Code style run: | - mh_metric . --ci + mh_style --process-slx - - name: Miss_hit code style + - name: MISS_HIT Metrics run: | - mh_style . + mh_metric --ci + + - name: MISS_HIT Bug finder + run: | + mh_lint diff --git a/docs/requirements.txt b/requirements.txt similarity index 82% rename from docs/requirements.txt rename to requirements.txt index 42ea70da..992d0ece 100644 --- a/docs/requirements.txt +++ b/requirements.txt @@ -2,4 +2,4 @@ Sphinx sphinxcontrib-matlabdomain sphinxcontrib-napoleon sphinx_rtd_theme -miss_hit \ No newline at end of file +miss_hit==0.9.15 \ No newline at end of file From d8d4c5d321b4c8f5ee65fde3ce559a285ecec956 Mon Sep 17 00:00:00 2001 From: Remi Gau Date: Thu, 24 Dec 2020 09:15:44 +0100 Subject: [PATCH 2/2] fix mh errors --- src/checkCFG.m | 2 +- src/templates/{templateTest.m => test_templateTest.m} | 0 src/utils/checkCppBidsDependencies.m | 4 ++-- src/utils/printCreditsCppBids.m | 4 ++-- tests/test_createValidName.m | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) rename src/templates/{templateTest.m => test_templateTest.m} (100%) diff --git a/src/checkCFG.m b/src/checkCFG.m index 762681ca..d46ed601 100644 --- a/src/checkCFG.m +++ b/src/checkCFG.m @@ -354,7 +354,7 @@ % REQUIRED Position of the dewar during the MEG scan: "upright", "supine" or % "degrees" of angle from vertical: for example on CTF systems, - % upright=15°, supine = 90°: + % upright=15 deg, supine = 90 deg: fieldsToSet.bids.meg.DewarPosition = []; % REQUIRED List of temporal and/or spatial software filters applied, or ideally diff --git a/src/templates/templateTest.m b/src/templates/test_templateTest.m similarity index 100% rename from src/templates/templateTest.m rename to src/templates/test_templateTest.m diff --git a/src/utils/checkCppBidsDependencies.m b/src/utils/checkCppBidsDependencies.m index 1bb82894..4512ee43 100644 --- a/src/utils/checkCppBidsDependencies.m +++ b/src/utils/checkCppBidsDependencies.m @@ -22,10 +22,10 @@ function checkCppBidsDependencies(cfg) pth = fullfile(fileparts(mfilename('fullpath')), '..', '..'); addpath(fullfile(pth, 'lib', 'utils')); - + pth = fullfile(fileparts(mfilename('fullpath')), '..', '..'); pth = abspath(pth); - + checkSubmodule(fullfile(pth, 'lib', 'JSONio')); checkSubmodule(fullfile(pth, 'lib', 'bids-matlab')); diff --git a/src/utils/printCreditsCppBids.m b/src/utils/printCreditsCppBids.m index e7547ce0..ed8bced2 100644 --- a/src/utils/printCreditsCppBids.m +++ b/src/utils/printCreditsCppBids.m @@ -28,11 +28,11 @@ function printCreditsCppBids(cfg) if verbose > 1 contributors = { ... - 'Rémi Gau', ... + 'Remi Gau', ... 'Marco Barilari', ... 'Ceren Battal', ... 'Tomas Lenc'}; - + DOI_URL = 'https://doi.org/10.5281/zenodo.4007674'; repoURL = 'https://github.com/cpp-lln-lab/CPP_BIDS'; diff --git a/tests/test_createValidName.m b/tests/test_createValidName.m index 7486468a..44890365 100644 --- a/tests/test_createValidName.m +++ b/tests/test_createValidName.m @@ -12,7 +12,7 @@ function test_createTaskNameRemoveInvalidCharacters() %% set up - taskName = '&|@#-_(§!{})[]ù%£+/=:;.?,\<> visual task'; + taskName = '&|@#-_(!{})[]%+/=:;.?,\<> visual task'; [~, taskNameValid] = createValidName(taskName);