server doesn't throw exception/error when failed to start #166

Closed
alexk1976 opened this Issue Nov 6, 2012 · 5 comments

Comments

Projects
None yet
2 participants
@alexk1976

Server doesn't throw exception/error when failed to start
E.g. when start_listening() funtion failed (cannot open socket on a port...) there is no any indication for the client code.
The funtion doesn't return error value or exception
Am i missed anything?

@ghost ghost assigned deanberris Nov 7, 2012

@deanberris

This comment has been minimized.

Show comment
Hide comment
@deanberris

deanberris Nov 7, 2012

Member

Yes, this is a problem. I might have time to fix it but not until I'm done with other things I'm working on. Can you try fixing it and sending a pull request?

Member

deanberris commented Nov 7, 2012

Yes, this is a problem. I might have time to fix it but not until I'm done with other things I'm working on. Can you try fixing it and sending a pull request?

@alexk1976

This comment has been minimized.

Show comment
Hide comment
@alexk1976

alexk1976 Nov 8, 2012

I’ve fixed it for me and can send you the code if you want
The pull request procedure for the first time will take me some time– maybe next week
Thank you

From: Dean Michael Berris [mailto:notifications@github.com]
Sent: Wednesday, November 07, 2012 02:26
To: cpp-netlib/cpp-netlib
Cc: Kunin, Alex
Subject: Re: [cpp-netlib] server doesn't throw exception/error when failed to start (#166)

Yes, this is a problem. I might have time to fix it but not until I'm done with other things I'm working on. Can you try fixing it and sending a pull request?


Reply to this email directly or view it on GitHubhttps://github.com/cpp-netlib/cpp-netlib/issues/166#issuecomment-10133741.


Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

I’ve fixed it for me and can send you the code if you want
The pull request procedure for the first time will take me some time– maybe next week
Thank you

From: Dean Michael Berris [mailto:notifications@github.com]
Sent: Wednesday, November 07, 2012 02:26
To: cpp-netlib/cpp-netlib
Cc: Kunin, Alex
Subject: Re: [cpp-netlib] server doesn't throw exception/error when failed to start (#166)

Yes, this is a problem. I might have time to fix it but not until I'm done with other things I'm working on. Can you try fixing it and sending a pull request?


Reply to this email directly or view it on GitHubhttps://github.com/cpp-netlib/cpp-netlib/issues/166#issuecomment-10133741.


Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

@deanberris

This comment has been minimized.

Show comment
Hide comment
@deanberris

deanberris Nov 9, 2012

Member

That's alright, thanks Alex!

On Fri, Nov 9, 2012 at 12:16 AM, alexk1976 notifications@github.com wrote:

I’ve fixed it for me and can send you the code if you want
The pull request procedure for the first time will take me some time–
maybe next week
Thank you

From: Dean Michael Berris [mailto:notifications@github.com]
Sent: Wednesday, November 07, 2012 02:26
To: cpp-netlib/cpp-netlib
Cc: Kunin, Alex
Subject: Re: [cpp-netlib] server doesn't throw exception/error when failed
to start (#166)

Yes, this is a problem. I might have time to fix it but not until I'm done
with other things I'm working on. Can you try fixing it and sending a pull
request?


Reply to this email directly or view it on GitHub<
https://github.com/cpp-netlib/cpp-netlib/issues/166#issuecomment-10133741>.


Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


Reply to this email directly or view it on GitHubhttps://github.com/cpp-netlib/cpp-netlib/issues/166#issuecomment-10187403.

Dean Michael Berris | Software Engineer
Google

Member

deanberris commented Nov 9, 2012

That's alright, thanks Alex!

On Fri, Nov 9, 2012 at 12:16 AM, alexk1976 notifications@github.com wrote:

I’ve fixed it for me and can send you the code if you want
The pull request procedure for the first time will take me some time–
maybe next week
Thank you

From: Dean Michael Berris [mailto:notifications@github.com]
Sent: Wednesday, November 07, 2012 02:26
To: cpp-netlib/cpp-netlib
Cc: Kunin, Alex
Subject: Re: [cpp-netlib] server doesn't throw exception/error when failed
to start (#166)

Yes, this is a problem. I might have time to fix it but not until I'm done
with other things I'm working on. Can you try fixing it and sending a pull
request?


Reply to this email directly or view it on GitHub<
https://github.com/cpp-netlib/cpp-netlib/issues/166#issuecomment-10133741>.


Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.


Reply to this email directly or view it on GitHubhttps://github.com/cpp-netlib/cpp-netlib/issues/166#issuecomment-10187403.

Dean Michael Berris | Software Engineer
Google

@deanberris

This comment has been minimized.

Show comment
Hide comment
@deanberris

deanberris Jul 3, 2013

Member

@alexk1976 -- do you remember if you've sent in a pull request to fix this? If not I can fix this on 0.10.1 too.

Member

deanberris commented Jul 3, 2013

@alexk1976 -- do you remember if you've sent in a pull request to fix this? If not I can fix this on 0.10.1 too.

@alexk1976

This comment has been minimized.

Show comment
Hide comment
@alexk1976

alexk1976 Jul 4, 2013

No. I haven’t..
Thanks

From: Dean Michael Berris [mailto:notifications@github.com]
Sent: Wednesday, July 03, 2013 13:49
To: cpp-netlib/cpp-netlib
Cc: Kunin, Alex
Subject: Re: [cpp-netlib] server doesn't throw exception/error when failed to start (#166)

@alexk1976https://github.com/alexk1976 -- do you remember if you've sent in a pull request to fix this? If not I can fix this on 0.10.1 too.

Reply to this email directly or view it on GitHubhttps://github.com/cpp-netlib/cpp-netlib/issues/166#issuecomment-20407972.

Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

No. I haven’t..
Thanks

From: Dean Michael Berris [mailto:notifications@github.com]
Sent: Wednesday, July 03, 2013 13:49
To: cpp-netlib/cpp-netlib
Cc: Kunin, Alex
Subject: Re: [cpp-netlib] server doesn't throw exception/error when failed to start (#166)

@alexk1976https://github.com/alexk1976 -- do you remember if you've sent in a pull request to fix this? If not I can fix this on 0.10.1 too.

Reply to this email directly or view it on GitHubhttps://github.com/cpp-netlib/cpp-netlib/issues/166#issuecomment-20407972.

Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

deanberris added a commit that referenced this issue Jul 4, 2013

Make both server starts throw on error.
There's an asymmetry between the error reporting in the asynchronous and
synchronous server implementations. The update to the test makes sure
the symmetry is enforced.

Fixes #166

deanberris added a commit that referenced this issue Jul 4, 2013

@deanberris deanberris closed this Jul 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment