Issue #161 #163

Merged
merged 4 commits into from Dec 8, 2012

Conversation

Projects
None yet
3 participants
@maxim-ky

No description provided.

@ghost ghost assigned glynos Oct 30, 2012

@deanberris

This comment has been minimized.

Show comment
Hide comment
@deanberris

deanberris Oct 30, 2012

Member

I think I'll be a little more comfortable merging this if there was also a test making sure that this did what it's supposed to do. Glyn, please feel free to merge and add the test later if you think this is a reasonable implementation.

Member

deanberris commented Oct 30, 2012

I think I'll be a little more comfortable merging this if there was also a test making sure that this did what it's supposed to do. Glyn, please feel free to merge and add the test later if you think this is a reasonable implementation.

@glynos

This comment has been minimized.

Show comment
Hide comment
@glynos

glynos Oct 30, 2012

Member

Yes, please add a test case that should fail before the code fix and that succeeds after. You can put this test inside uri_test.cpp.

Member

glynos commented Oct 30, 2012

Yes, please add a test case that should fail before the code fix and that succeeds after. You can put this test inside uri_test.cpp.

@maxim-ky

This comment has been minimized.

Show comment
Hide comment
@maxim-ky

maxim-ky Dec 7, 2012

I added the test case and the fix with addition of typedef's in network::http::request_header/response_header because header concept requirements. Async http server can't be build without this fix.

maxim-ky commented Dec 7, 2012

I added the test case and the fix with addition of typedef's in network::http::request_header/response_header because header concept requirements. Async http server can't be build without this fix.

@glynos glynos merged commit 2f1dee8 into cpp-netlib:master Dec 8, 2012

deanberris added a commit that referenced this pull request Jan 20, 2014

deanberris added a commit that referenced this pull request Jan 20, 2014

leecoder pushed a commit to leecoder/cpp-netlib that referenced this pull request Apr 14, 2015

leecoder pushed a commit to leecoder/cpp-netlib that referenced this pull request Apr 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment