Added a client certificate support. #361

Merged
merged 1 commit into from Jan 20, 2014

Conversation

Projects
None yet
2 participants
@redboltz

Added client::options to openssl_certificate_file() and openssl_private_key_file(). They correspond to Boost.Asio's use_certificate_file() and use_private_key_file().

Naming decisions:

  1. The same as other member functions naming rules. (e.g. openssl_verify_path() )
  2. Easy to find the Boost.Asio's corresponding member functions.

Note:
I have an idea to rename the existing member function openssl_certificate() to some different name. But it would be a breaking change and I believe that I shouldn't include it in this pull request.
The reasons that I'd like to rename openssl_certificate() are as follows:

  1. openssl_certificate() corresponds to Boost.Asio's load_verify_file() so the new name should be openssl_load_verify_file() or openssl_verify_file(). Latter is better in cpp-netlib's naming mannar.
  2. This pull request adds openssl_certificate_file() and I believe that it is an apropriate name. But openssl_certificate_file() and openssl_certificate() are confusing.

If you agree with my idea, I'm ready to make a pull request. For existing users, keeping openssl_certificate() as a deprecated alias of openssl_verify_file().

@deanberris

This comment has been minimized.

Show comment
Hide comment
@deanberris

deanberris Jan 20, 2014

Member

LGTM

Well done @redboltz -- this looks very good! I'm merging this in. :)

Thank you for doing this!

Member

deanberris commented Jan 20, 2014

LGTM

Well done @redboltz -- this looks very good! I'm merging this in. :)

Thank you for doing this!

deanberris added a commit that referenced this pull request Jan 20, 2014

@deanberris deanberris merged commit 8c28ccc into cpp-netlib:0.11-devel Jan 20, 2014

@ghost ghost assigned deanberris Jan 20, 2014

leecoder pushed a commit to leecoder/cpp-netlib that referenced this pull request Apr 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment