Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cpp-netlib-http-client_get_timeout_test - change broken link #532

Closed
wants to merge 1 commit into from
Closed

fix cpp-netlib-http-client_get_timeout_test - change broken link #532

wants to merge 1 commit into from

Conversation

cnagune
Copy link

@cnagune cnagune commented May 21, 2015

  • problem
$ make test
Running tests...
...
      Start 15: cpp-netlib-http-client_get_timeout_test
15/20 Test #15: cpp-netlib-http-client_get_timeout_test .............***Failed   13.78 sec
...
$ curl "http://cznic.dl.sourceforge.net/project/boost/boost/1.55.0/boost_1_55_0.tar.bz2"
<html>
<head><title>302 Found</title></head>
<body bgcolor="white">
<center><h1>302 Found</h1></center>
<hr><center>nginx</center>
</body>
</html>
  • fix
$ make test
Running tests...
...
      Start 15: cpp-netlib-http-client_get_timeout_test
15/20 Test #15: cpp-netlib-http-client_get_timeout_test .............   Passed   15.58 sec
...

@leecoder
Copy link

I've rewrote this tc using localhost server. (leecoder/cpp-netlib@4271ca5)

@deanberris
Copy link
Member

It looks like it's still broken @cnagune -- @leecoder did you have a PR for this?

@leecoder
Copy link

I've created a new PR #533 .

@deanberris
Copy link
Member

Thanks @leecoder -- @cnagune I think you can close this now that we have a more reliable fix in the meantime. Thank you both for your efforts and contributions!

@cnagune cnagune closed this May 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cnagune @leecoder @deanberris