Skip to content

Fix GIT_SUBMODULE mode for nested submodule (fixes #395) #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbsheth merged 1 commit into from
Jul 12, 2021
Merged

Fix GIT_SUBMODULE mode for nested submodule (fixes #395) #437

rbsheth merged 1 commit into from
Jul 12, 2021

Conversation

@hjmallon
Copy link

@hjmallon hjmallon commented Jul 9, 2021

  • I've checked this Git style guide. [Yes]
  • I've checked this CMake style guide. [Yes]
  • My change will work with CMake 3.2 (minimum requirement for Hunter). [Yes]
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes]

Finally got round to fixing this issue: #395

@rbsheth rbsheth linked an issue Jul 12, 2021 that may be closed by this pull request
GIT_SUBMODULE mode doesn't work on nested submodules #395
Closed
@rbsheth rbsheth merged commit cc21cf8 into cpp-pm:master Jul 12, 2021
@rbsheth
Copy link
Member

rbsheth commented Jul 12, 2021

Released: https://github.com/cpp-pm/hunter/releases/tag/v0.23.312

@hjmallon hjmallon deleted the fix_submod_nest branch February 8, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GIT_SUBMODULE mode doesn't work on nested submodules

2 participants

@hjmallon @rbsheth